[drupal-devel] [feature] Usability improvement to forum module
Issue status update for http://drupal.org/node/18795 Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: nysus Updated by: nysus Status: patch Attachment: http://drupal.org/files/issues/forum_patch.patch (412 bytes) Here's another usability improvement to the forum. Rather than return no table when no containers or forums exist, a message is displayed inside the table telling the user that no containers or forums exist and how to create a new one. nysus
Issue status update for http://drupal.org/node/18795 Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: nysus Updated by: drumm Status: patch +1 for the functionality. -1 for the specific implementation. Other places in the code use em rather than strong. The colspan attribute should be used to stretch this row across the whole table. The instructions on the second line could be a good idea, but should be hidden if the user does not have permissions to do that action. Do we want to update other places to do the same thing? drumm Previous comments: ------------------------------------------------------------------------ March 12, 2005 - 14:24 : nysus Attachment: http://drupal.org/files/issues/forum_patch.patch (412 bytes) Here's another usability improvement to the forum. Rather than return no table when no containers or forums exist, a message is displayed inside the table telling the user that no containers or forums exist and how to create a new one.
I'm currently making a patch for all the modules who do this.. Only a little more in a drupal-way.. Please be patient, I'll post a patch within a day or 2.. Stefan. Op 17-mrt-05 om 19:10 heeft drumm het volgende geschreven:
Issue status update for http://drupal.org/node/18795
Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: nysus Updated by: drumm Status: patch
+1 for the functionality. -1 for the specific implementation. Other places in the code use em rather than strong. The colspan attribute should be used to stretch this row across the whole table. The instructions on the second line could be a good idea, but should be hidden if the user does not have permissions to do that action. Do we want to update other places to do the same thing?
drumm
Previous comments: ----------------------------------------------------------------------- -
March 12, 2005 - 14:24 : nysus
Attachment: http://drupal.org/files/issues/forum_patch.patch (412 bytes)
Here's another usability improvement to the forum. Rather than return no table when no containers or forums exist, a message is displayed inside the table telling the user that no containers or forums exist and how to create a new one.
Issue status update for http://drupal.org/node/18795 Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: nysus Updated by: Steven Status: patch Not to mention missing t()'s... Steven Previous comments: ------------------------------------------------------------------------ March 12, 2005 - 21:24 : nysus Attachment: http://drupal.org/files/issues/forum_patch.patch (412 bytes) Here's another usability improvement to the forum. Rather than return no table when no containers or forums exist, a message is displayed inside the table telling the user that no containers or forums exist and how to create a new one. ------------------------------------------------------------------------ March 17, 2005 - 19:10 : drumm +1 for the functionality. -1 for the specific implementation. Other places in the code use em rather than strong. The colspan attribute should be used to stretch this row across the whole table. The instructions on the second line could be a good idea, but should be hidden if the user does not have permissions to do that action. Do we want to update other places to do the same thing?
Issue status update for http://drupal.org/node/18795 Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: nysus Updated by: nysus Status: active Attachment: http://drupal.org/files/issues/forum_10.patch (0 bytes) Revised patch attached. It addresses problems noted by others in my original patch. However, this patch revision does not address drumm's recommendation to hide the message from anauthorized users. Unless I'm mistaken, users without the permission to administer forums will receive an "Access denied" message and would not see the help message anyway. Please correct me if I'm wrong on this. nysus Previous comments: ------------------------------------------------------------------------ March 12, 2005 - 15:24 : nysus Attachment: http://drupal.org/files/issues/forum_patch.patch (412 bytes) Here's another usability improvement to the forum. Rather than return no table when no containers or forums exist, a message is displayed inside the table telling the user that no containers or forums exist and how to create a new one. ------------------------------------------------------------------------ March 17, 2005 - 13:10 : drumm +1 for the functionality. -1 for the specific implementation. Other places in the code use em rather than strong. The colspan attribute should be used to stretch this row across the whole table. The instructions on the second line could be a good idea, but should be hidden if the user does not have permissions to do that action. Do we want to update other places to do the same thing? ------------------------------------------------------------------------ March 17, 2005 - 13:18 : Steven Not to mention missing t()'s... ------------------------------------------------------------------------ March 23, 2005 - 16:25 : Dries Waiting for a new patch. Marking this 'active'.
Issue status update for http://drupal.org/node/18795 Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: nysus Updated by: nysus Status: active Patch showed up as zero bytes. I think my Linux box crashed in the middle of tranferring the file. I'll reupload when I get it back up. nysus Previous comments: ------------------------------------------------------------------------ March 12, 2005 - 15:24 : nysus Attachment: http://drupal.org/files/issues/forum_patch.patch (412 bytes) Here's another usability improvement to the forum. Rather than return no table when no containers or forums exist, a message is displayed inside the table telling the user that no containers or forums exist and how to create a new one. ------------------------------------------------------------------------ March 17, 2005 - 13:10 : drumm +1 for the functionality. -1 for the specific implementation. Other places in the code use em rather than strong. The colspan attribute should be used to stretch this row across the whole table. The instructions on the second line could be a good idea, but should be hidden if the user does not have permissions to do that action. Do we want to update other places to do the same thing? ------------------------------------------------------------------------ March 17, 2005 - 13:18 : Steven Not to mention missing t()'s... ------------------------------------------------------------------------ March 23, 2005 - 16:25 : Dries Waiting for a new patch. Marking this 'active'. ------------------------------------------------------------------------ March 24, 2005 - 16:44 : nysus Attachment: http://drupal.org/files/issues/forum_10.patch (0 bytes) Revised patch attached. It addresses problems noted by others in my original patch. However, this patch revision does not address drumm's recommendation to hide the message from anauthorized users. Unless I'm mistaken, users without the permission to administer forums will receive an "Access denied" message and would not see the help message anyway. Please correct me if I'm wrong on this.
Issue status update for http://drupal.org/node/18795 Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: nysus Updated by: nysus Status: active Attachment: http://drupal.org/files/issues/forum_11.patch (438 bytes) OK, let's try uploding this patch again. On the old clunker machine I have, even Debian crashes from time to time. nysus Previous comments: ------------------------------------------------------------------------ March 12, 2005 - 15:24 : nysus Attachment: http://drupal.org/files/issues/forum_patch.patch (412 bytes) Here's another usability improvement to the forum. Rather than return no table when no containers or forums exist, a message is displayed inside the table telling the user that no containers or forums exist and how to create a new one. ------------------------------------------------------------------------ March 17, 2005 - 13:10 : drumm +1 for the functionality. -1 for the specific implementation. Other places in the code use em rather than strong. The colspan attribute should be used to stretch this row across the whole table. The instructions on the second line could be a good idea, but should be hidden if the user does not have permissions to do that action. Do we want to update other places to do the same thing? ------------------------------------------------------------------------ March 17, 2005 - 13:18 : Steven Not to mention missing t()'s... ------------------------------------------------------------------------ March 23, 2005 - 16:25 : Dries Waiting for a new patch. Marking this 'active'. ------------------------------------------------------------------------ March 24, 2005 - 16:44 : nysus Attachment: http://drupal.org/files/issues/forum_10.patch (0 bytes) Revised patch attached. It addresses problems noted by others in my original patch. However, this patch revision does not address drumm's recommendation to hide the message from anauthorized users. Unless I'm mistaken, users without the permission to administer forums will receive an "Access denied" message and would not see the help message anyway. Please correct me if I'm wrong on this. ------------------------------------------------------------------------ March 24, 2005 - 16:51 : nysus Patch showed up as zero bytes. I think my Linux box crashed in the middle of tranferring the file. I'll reupload when I get it back up.
Issue status update for http://drupal.org/node/18795 Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: nysus Updated by: nysus -Status: active +Status: patch new patch uploaded nysus Previous comments: ------------------------------------------------------------------------ March 12, 2005 - 15:24 : nysus Attachment: http://drupal.org/files/issues/forum_patch.patch (412 bytes) Here's another usability improvement to the forum. Rather than return no table when no containers or forums exist, a message is displayed inside the table telling the user that no containers or forums exist and how to create a new one. ------------------------------------------------------------------------ March 17, 2005 - 13:10 : drumm +1 for the functionality. -1 for the specific implementation. Other places in the code use em rather than strong. The colspan attribute should be used to stretch this row across the whole table. The instructions on the second line could be a good idea, but should be hidden if the user does not have permissions to do that action. Do we want to update other places to do the same thing? ------------------------------------------------------------------------ March 17, 2005 - 13:18 : Steven Not to mention missing t()'s... ------------------------------------------------------------------------ March 23, 2005 - 16:25 : Dries Waiting for a new patch. Marking this 'active'. ------------------------------------------------------------------------ March 24, 2005 - 16:44 : nysus Attachment: http://drupal.org/files/issues/forum_10.patch (0 bytes) Revised patch attached. It addresses problems noted by others in my original patch. However, this patch revision does not address drumm's recommendation to hide the message from anauthorized users. Unless I'm mistaken, users without the permission to administer forums will receive an "Access denied" message and would not see the help message anyway. Please correct me if I'm wrong on this. ------------------------------------------------------------------------ March 24, 2005 - 16:51 : nysus Patch showed up as zero bytes. I think my Linux box crashed in the middle of tranferring the file. I'll reupload when I get it back up. ------------------------------------------------------------------------ March 24, 2005 - 20:32 : nysus Attachment: http://drupal.org/files/issues/forum_11.patch (438 bytes) OK, let's try uploding this patch again. On the old clunker machine I have, even Debian crashes from time to time.
Issue status update for http://drupal.org/node/18795 Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: nysus Updated by: Steven -Status: patch +Status: fixed I commited a modified patch: - The br doesn't belong there. It is layout, not semantics. - You should avoid telling people to click somewhere. Just provide a link directly. Before "There are no existing containers or forums. Click on the "add container" or "add forum" tab to create one. " After "There are no existing containers or forums. You may add some on the add container [1] or add forum [2] pages. " [1] http://drupal.org/%container [2] http://drupal.org/%forum Steven Previous comments: ------------------------------------------------------------------------ March 12, 2005 - 21:24 : nysus Attachment: http://drupal.org/files/issues/forum_patch.patch (412 bytes) Here's another usability improvement to the forum. Rather than return no table when no containers or forums exist, a message is displayed inside the table telling the user that no containers or forums exist and how to create a new one. ------------------------------------------------------------------------ March 17, 2005 - 19:10 : drumm +1 for the functionality. -1 for the specific implementation. Other places in the code use em rather than strong. The colspan attribute should be used to stretch this row across the whole table. The instructions on the second line could be a good idea, but should be hidden if the user does not have permissions to do that action. Do we want to update other places to do the same thing? ------------------------------------------------------------------------ March 17, 2005 - 19:18 : Steven Not to mention missing t()'s... ------------------------------------------------------------------------ March 23, 2005 - 22:25 : Dries Waiting for a new patch. Marking this 'active'. ------------------------------------------------------------------------ March 24, 2005 - 22:44 : nysus Attachment: http://drupal.org/files/issues/forum_10.patch (0 bytes) Revised patch attached. It addresses problems noted by others in my original patch. However, this patch revision does not address drumm's recommendation to hide the message from anauthorized users. Unless I'm mistaken, users without the permission to administer forums will receive an "Access denied" message and would not see the help message anyway. Please correct me if I'm wrong on this. ------------------------------------------------------------------------ March 24, 2005 - 22:51 : nysus Patch showed up as zero bytes. I think my Linux box crashed in the middle of tranferring the file. I'll reupload when I get it back up. ------------------------------------------------------------------------ March 25, 2005 - 02:32 : nysus Attachment: http://drupal.org/files/issues/forum_11.patch (438 bytes) OK, let's try uploding this patch again. On the old clunker machine I have, even Debian crashes from time to time. ------------------------------------------------------------------------ March 27, 2005 - 03:06 : nysus new patch uploaded
participants (4)
-
drumm -
nysus
-
Stefan Nagtegaal -
Steven