Hello world, I just committed http://drupal.org/node/99625 -- this means that E_ALL mode is now enabled in Drupal HEAD. We might want to disable this when we freeze Drupal 6, but for the duration of the development cycle it is a good idea to turn this on. It makes for better code. -- Dries Buytaert :: http://www.buytaert.net/
On 1/23/07 2:24 PM, Dries Buytaert wrote:
Hello world,
I just committed http://drupal.org/node/99625 -- this means that E_ALL mode is now enabled in Drupal HEAD. We might want to disable this when we freeze Drupal 6, but for the duration of the development cycle it is a good idea to turn this on. It makes for better code.
+1 :) -- James Walker :: http://walkah.net/ :: xmpp:walkah@walkah.net
[Tue Jan 23 16:14:03 2007] [error] [client 1.2.3.4] PHP Notice: Undefined property: +1 :) James Walker wrote:
On 1/23/07 2:24 PM, Dries Buytaert wrote:
Hello world,
I just committed http://drupal.org/node/99625 -- this means that E_ALL mode is now enabled in Drupal HEAD. We might want to disable this when we freeze Drupal 6, but for the duration of the development cycle it is a good idea to turn this on. It makes for better code.
+1 :)
On Wednesday 24 January 2007 03:24, Dries Buytaert wrote:
Hello world,
I just committed http://drupal.org/node/99625 -- this means that E_ALL mode is now enabled in Drupal HEAD. We might want to disable this when we freeze Drupal 6, but for the duration of the development cycle it is a good idea to turn this on. It makes for better code.
:D A:.
On 24/01/07, Dries Buytaert <dries.buytaert@gmail.com> wrote:
Hello world,
I just committed http://drupal.org/node/99625 -- this means that E_ALL mode is now enabled in Drupal HEAD. We might want to disable this when we freeze Drupal 6, but for the duration of the development cycle it is a good idea to turn this on. It makes for better code.
Can we please restrict notices to the watchdog at least until FAPI is made E_ALL compliant? It is currently rather counter-productive. -K
On 1/23/07, Karthik <narakasura@gmail.com> wrote:
Can we please restrict notices to the watchdog at least until FAPI is made E_ALL compliant? It is currently rather counter-productive.
I think the whole point is to make it annoying enough that it'll get fixed quickly. It can't be that bad or you'd have rolled a patch for it right? ;) andrew
I am willing to help with coordination and submission of patches to achieve E_ALL compliance in core, but I'm not personally going to take an asynchronous approach. It simply isn't an efficient use of my time. http://drupal.org/node/103250 is ready to fix a solid batch of errors but has received almost no attention over the past month. Once that is committed I will go through a round of testing and submit another patch for key post-install functionality, repeating until finished. Any development+testing assistance is very welcome, but I'm not going to waste time maintaining multiple E_ALL patches in a dynamic HEAD environment if no one is willing to test and review them. .ck andrew morton wrote:
On 1/23/07, Karthik <narakasura@gmail.com> wrote:
Can we please restrict notices to the watchdog at least until FAPI is made E_ALL compliant? It is currently rather counter-productive.
I think the whole point is to make it annoying enough that it'll get fixed quickly. It can't be that bad or you'd have rolled a patch for it right? ;)
andrew
On 23-Jan-07, at 2:24 PM, Dries Buytaert wrote:
Hello world,
I just committed http://drupal.org/node/99625 -- this means that E_ALL mode is now enabled in Drupal HEAD. We might want to disable this when we freeze Drupal 6, but for the duration of the development cycle it is a good idea to turn this on. It makes for better code.
For those interested in fixing the glaring red errors everywhere ;) all efforts should be condensed into two issues: - http://drupal.org/node/103250 - E_ALL compliance during installation - http://drupal.org/node/112715 - E_ALL compliance: Fix all remaining notices Should be basically self-explanatory, but anything that pops up when you're going through the installation goes in issue #1, and everything else goes in issue #2. Per Steven, single patches with the same types of changes are easier to review. The sooner these patches get reviews/attention, the sooner the screaming red errors go away and HEAD is somewhat usable. ;) -Angie
participants (8)
-
andrew morton -
Angela Byron -
Augustin (Beginner) -
Chris Kennedy -
Dries Buytaert -
James Walker -
Karthik -
Scott McLewin