[drupal-devel] [feature] Add subject to contact module
Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: kbahey Reported by: kbahey Updated by: kbahey Status: patch Attachment: http://drupal.org/files/issues/contact.module-subject.patch (1.93 KB) I find it very undescriptive when I recieve a message from Drupal with the subject "message from username". This patch adds a "subject" field for the contact.module which the user can fill, and would tell you what they want right away. Oh, and it helps group the 'conversation' on Gmail into something meaningful. (Note, I have not tested this since I do not have a CVS installation at the moment. Appreciate if someone can test it). kbahey -- View: http://drupal.org/node/16590 Edit: http://drupal.org/project/comments/add/16590
Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: kbahey Reported by: kbahey Updated by: kbahey Status: patch Did this patch make it? Any objections to it? kbahey Previous comments: ------------------------------------------------------------------------ February 1, 2005 - 21:26 : kbahey Attachment: http://drupal.org/files/issues/contact.module-subject.patch (1.93 KB) I find it very undescriptive when I recieve a message from Drupal with the subject "message from username". This patch adds a "subject" field for the contact.module which the user can fill, and would tell you what they want right away. Oh, and it helps group the 'conversation' on Gmail into something meaningful. (Note, I have not tested this since I do not have a CVS installation at the moment. Appreciate if someone can test it). -- View: http://drupal.org/node/16590 Edit: http://drupal.org/project/comments/add/16590
Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: kbahey Reported by: kbahey Updated by: kbahey -Status: postponed +Status: patch This is badly needed. Just today I got a message from walkah and Gmail grouped it in a previous conversation with someone else, just because the subject is "message from kbahey". We have to get this to CVS. kbahey Previous comments: ------------------------------------------------------------------------ February 1, 2005 - 21:26 : kbahey Attachment: http://drupal.org/files/issues/contact.module-subject.patch (1.93 KB) I find it very undescriptive when I recieve a message from Drupal with the subject "message from username". This patch adds a "subject" field for the contact.module which the user can fill, and would tell you what they want right away. Oh, and it helps group the 'conversation' on Gmail into something meaningful. (Note, I have not tested this since I do not have a CVS installation at the moment. Appreciate if someone can test it). ------------------------------------------------------------------------ February 9, 2005 - 15:20 : kbahey Did this patch make it? Any objections to it? ------------------------------------------------------------------------ February 10, 2005 - 15:02 : Dries I'll commit this patch when there is more demand for it. ------------------------------------------------------------------------ February 10, 2005 - 15:12 : killes@www.drop.org I'd like to see this applied. An email got to have a subject. -- View: http://drupal.org/node/16590 Edit: http://drupal.org/project/comments/add/16590
Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: kbahey Reported by: kbahey Updated by: Morbus Iff Status: patch +1 from me. Morbus Iff Previous comments: ------------------------------------------------------------------------ February 1, 2005 - 21:26 : kbahey Attachment: http://drupal.org/files/issues/contact.module-subject.patch (1.93 KB) I find it very undescriptive when I recieve a message from Drupal with the subject "message from username". This patch adds a "subject" field for the contact.module which the user can fill, and would tell you what they want right away. Oh, and it helps group the 'conversation' on Gmail into something meaningful. (Note, I have not tested this since I do not have a CVS installation at the moment. Appreciate if someone can test it). ------------------------------------------------------------------------ February 9, 2005 - 15:20 : kbahey Did this patch make it? Any objections to it? ------------------------------------------------------------------------ February 10, 2005 - 15:02 : Dries I'll commit this patch when there is more demand for it. ------------------------------------------------------------------------ February 10, 2005 - 15:12 : killes@www.drop.org I'd like to see this applied. An email got to have a subject. ------------------------------------------------------------------------ February 18, 2005 - 10:34 : kbahey This is badly needed. Just today I got a message from walkah and Gmail grouped it in a previous conversation with someone else, just because the subject is "message from kbahey". We have to get this to CVS. -- View: http://drupal.org/node/16590 Edit: http://drupal.org/project/comments/add/16590
Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: kbahey Reported by: kbahey Updated by: tangent Status: patch There is an added newline in the foreach which seems unnecessary. Some lines also have tabs which disrupts the indentation. Otherwise, +1 on the functionality. tangent Previous comments: ------------------------------------------------------------------------ February 1, 2005 - 21:26 : kbahey Attachment: http://drupal.org/files/issues/contact.module-subject.patch (1.93 KB) I find it very undescriptive when I recieve a message from Drupal with the subject "message from username". This patch adds a "subject" field for the contact.module which the user can fill, and would tell you what they want right away. Oh, and it helps group the 'conversation' on Gmail into something meaningful. (Note, I have not tested this since I do not have a CVS installation at the moment. Appreciate if someone can test it). ------------------------------------------------------------------------ February 9, 2005 - 15:20 : kbahey Did this patch make it? Any objections to it? ------------------------------------------------------------------------ February 10, 2005 - 15:02 : Dries I'll commit this patch when there is more demand for it. ------------------------------------------------------------------------ February 10, 2005 - 15:12 : killes@www.drop.org I'd like to see this applied. An email got to have a subject. ------------------------------------------------------------------------ February 18, 2005 - 10:34 : kbahey This is badly needed. Just today I got a message from walkah and Gmail grouped it in a previous conversation with someone else, just because the subject is "message from kbahey". We have to get this to CVS. ------------------------------------------------------------------------ February 18, 2005 - 10:42 : Morbus Iff +1 from me. -- View: http://drupal.org/node/16590 Edit: http://drupal.org/project/comments/add/16590
Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: kbahey Reported by: kbahey Updated by: Anonymous Status: patch +1 from me too. Since this is a simple useability extension, I hope that it will get into 4.6. Anonymous Previous comments: ------------------------------------------------------------------------ February 2, 2005 - 02:26 : kbahey Attachment: http://drupal.org/files/issues/contact.module-subject.patch (1.93 KB) I find it very undescriptive when I recieve a message from Drupal with the subject "message from username". This patch adds a "subject" field for the contact.module which the user can fill, and would tell you what they want right away. Oh, and it helps group the 'conversation' on Gmail into something meaningful. (Note, I have not tested this since I do not have a CVS installation at the moment. Appreciate if someone can test it). ------------------------------------------------------------------------ February 9, 2005 - 20:20 : kbahey Did this patch make it? Any objections to it? ------------------------------------------------------------------------ February 10, 2005 - 20:02 : Dries I'll commit this patch when there is more demand for it. ------------------------------------------------------------------------ February 10, 2005 - 20:12 : killes@www.drop.org I'd like to see this applied. An email got to have a subject. ------------------------------------------------------------------------ February 18, 2005 - 15:34 : kbahey This is badly needed. Just today I got a message from walkah and Gmail grouped it in a previous conversation with someone else, just because the subject is "message from kbahey". We have to get this to CVS. ------------------------------------------------------------------------ February 18, 2005 - 15:42 : Morbus Iff +1 from me. ------------------------------------------------------------------------ February 18, 2005 - 17:10 : tangent There is an added newline in the foreach which seems unnecessary. Some lines also have tabs which disrupts the indentation. Otherwise, +1 on the functionality. -- View: http://drupal.org/node/16590 Edit: http://drupal.org/project/comments/add/16590
Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: kbahey Reported by: kbahey Updated by: Goba Status: patch The previous 'me' was me :) Goba Previous comments: ------------------------------------------------------------------------ February 2, 2005 - 03:26 : kbahey Attachment: http://drupal.org/files/issues/contact.module-subject.patch (1.93 KB) I find it very undescriptive when I recieve a message from Drupal with the subject "message from username". This patch adds a "subject" field for the contact.module which the user can fill, and would tell you what they want right away. Oh, and it helps group the 'conversation' on Gmail into something meaningful. (Note, I have not tested this since I do not have a CVS installation at the moment. Appreciate if someone can test it). ------------------------------------------------------------------------ February 9, 2005 - 21:20 : kbahey Did this patch make it? Any objections to it? ------------------------------------------------------------------------ February 10, 2005 - 21:02 : Dries I'll commit this patch when there is more demand for it. ------------------------------------------------------------------------ February 10, 2005 - 21:12 : killes@www.drop.org I'd like to see this applied. An email got to have a subject. ------------------------------------------------------------------------ February 18, 2005 - 16:34 : kbahey This is badly needed. Just today I got a message from walkah and Gmail grouped it in a previous conversation with someone else, just because the subject is "message from kbahey". We have to get this to CVS. ------------------------------------------------------------------------ February 18, 2005 - 16:42 : Morbus Iff +1 from me. ------------------------------------------------------------------------ February 18, 2005 - 18:10 : tangent There is an added newline in the foreach which seems unnecessary. Some lines also have tabs which disrupts the indentation. Otherwise, +1 on the functionality. ------------------------------------------------------------------------ February 18, 2005 - 18:38 : Anonymous +1 from me too. Since this is a simple useability extension, I hope that it will get into 4.6. -- View: http://drupal.org/node/16590 Edit: http://drupal.org/project/comments/add/16590
Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: kbahey Reported by: kbahey Updated by: kbahey -Status: fixed +Status: patch I think we missed something in this patch. The form_textfield has an argument that the maximum is 8 characters. This is too short. Should be 30 characters or more. Line 125 in HEAD. kbahey Previous comments: ------------------------------------------------------------------------ February 1, 2005 - 21:26 : kbahey Attachment: http://drupal.org/files/issues/contact.module-subject.patch (1.93 KB) I find it very undescriptive when I recieve a message from Drupal with the subject "message from username". This patch adds a "subject" field for the contact.module which the user can fill, and would tell you what they want right away. Oh, and it helps group the 'conversation' on Gmail into something meaningful. (Note, I have not tested this since I do not have a CVS installation at the moment. Appreciate if someone can test it). ------------------------------------------------------------------------ February 9, 2005 - 15:20 : kbahey Did this patch make it? Any objections to it? ------------------------------------------------------------------------ February 10, 2005 - 15:02 : Dries I'll commit this patch when there is more demand for it. ------------------------------------------------------------------------ February 10, 2005 - 15:12 : killes@www.drop.org I'd like to see this applied. An email got to have a subject. ------------------------------------------------------------------------ February 18, 2005 - 10:34 : kbahey This is badly needed. Just today I got a message from walkah and Gmail grouped it in a previous conversation with someone else, just because the subject is "message from kbahey". We have to get this to CVS. ------------------------------------------------------------------------ February 18, 2005 - 10:42 : Morbus Iff +1 from me. ------------------------------------------------------------------------ February 18, 2005 - 12:10 : tangent There is an added newline in the foreach which seems unnecessary. Some lines also have tabs which disrupts the indentation. Otherwise, +1 on the functionality. ------------------------------------------------------------------------ February 18, 2005 - 12:38 : Anonymous +1 from me too. Since this is a simple useability extension, I hope that it will get into 4.6. ------------------------------------------------------------------------ February 18, 2005 - 12:38 : Goba The previous 'me' was me :) ------------------------------------------------------------------------ February 18, 2005 - 13:50 : Dries Committed to HEAD. -- View: http://drupal.org/node/16590 Edit: http://drupal.org/project/comments/add/16590
Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: kbahey Reported by: kbahey Updated by: Goba -Status: fixed +Status: patch Attachment: http://drupal.org/files/issues/Drupal.fix-contact-module-ws.patch (1.42 KB) Whitespace fixes after the patch... Goba Previous comments: ------------------------------------------------------------------------ February 2, 2005 - 03:26 : kbahey Attachment: http://drupal.org/files/issues/contact.module-subject.patch (1.93 KB) I find it very undescriptive when I recieve a message from Drupal with the subject "message from username". This patch adds a "subject" field for the contact.module which the user can fill, and would tell you what they want right away. Oh, and it helps group the 'conversation' on Gmail into something meaningful. (Note, I have not tested this since I do not have a CVS installation at the moment. Appreciate if someone can test it). ------------------------------------------------------------------------ February 9, 2005 - 21:20 : kbahey Did this patch make it? Any objections to it? ------------------------------------------------------------------------ February 10, 2005 - 21:02 : Dries I'll commit this patch when there is more demand for it. ------------------------------------------------------------------------ February 10, 2005 - 21:12 : killes@www.drop.org I'd like to see this applied. An email got to have a subject. ------------------------------------------------------------------------ February 18, 2005 - 16:34 : kbahey This is badly needed. Just today I got a message from walkah and Gmail grouped it in a previous conversation with someone else, just because the subject is "message from kbahey". We have to get this to CVS. ------------------------------------------------------------------------ February 18, 2005 - 16:42 : Morbus Iff +1 from me. ------------------------------------------------------------------------ February 18, 2005 - 18:10 : tangent There is an added newline in the foreach which seems unnecessary. Some lines also have tabs which disrupts the indentation. Otherwise, +1 on the functionality. ------------------------------------------------------------------------ February 18, 2005 - 18:38 : Anonymous +1 from me too. Since this is a simple useability extension, I hope that it will get into 4.6. ------------------------------------------------------------------------ February 18, 2005 - 18:38 : Goba The previous 'me' was me :) ------------------------------------------------------------------------ February 18, 2005 - 19:50 : Dries Committed to HEAD. ------------------------------------------------------------------------ February 18, 2005 - 22:35 : kbahey I think we missed something in this patch. The form_textfield has an argument that the maximum is 8 characters. This is too short. Should be 30 characters or more. Line 125 in HEAD. ------------------------------------------------------------------------ February 19, 2005 - 09:17 : Dries Fixed in HEAD. Thanks. -- View: http://drupal.org/node/16590 Edit: http://drupal.org/project/comments/add/16590
participants (5)
-
Anonymous -
Goba
-
kbahey
-
Morbus Iff
-
tangent