[drupal-devel] [feature] "File Attachments" group should be expanded if files are attached
Issue status update for http://drupal.org/node/28721 Post a follow up: http://drupal.org/project/comments/add/28721 Project: Drupal Version: cvs Component: upload.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: eafarris Updated by: eafarris Status: patch (code needs review) Attachment: http://drupal.org/files/issues/upload.module_1.patch (1.21 KB) Simple patch that will expand the "File Attachments" form_group_collapsible() by default if there are files attached. eafarris
Issue status update for http://drupal.org/node/28721 Post a follow up: http://drupal.org/project/comments/add/28721 Project: Drupal Version: cvs Component: upload.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: eafarris Updated by: drumm -Status: patch (code needs review) +Status: patch (code needs work) I think <?php $has_attachments ? FALSE : TRUE ?> can be replaced with <?php !$has_attachments ?> drumm Previous comments: ------------------------------------------------------------------------ Thu, 11 Aug 2005 23:33:17 +0000 : eafarris Attachment: http://drupal.org/files/issues/upload.module_1.patch (1.21 KB) Simple patch that will expand the "File Attachments" form_group_collapsible() by default if there are files attached.
Issue status update for http://drupal.org/node/28721 Post a follow up: http://drupal.org/project/comments/add/28721 Project: Drupal Version: cvs Component: upload.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: eafarris Updated by: eafarris -Status: patch (code needs work) +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/upload.module_2.patch (1.19 KB) Agreed. Here's an updated patch. eafarris Previous comments: ------------------------------------------------------------------------ Thu, 11 Aug 2005 23:33:17 +0000 : eafarris Attachment: http://drupal.org/files/issues/upload.module_1.patch (1.21 KB) Simple patch that will expand the "File Attachments" form_group_collapsible() by default if there are files attached. ------------------------------------------------------------------------ Fri, 12 Aug 2005 18:57:11 +0000 : drumm I think <?php $has_attachments ? FALSE : TRUE ?> can be replaced with <?php !$has_attachments ?>
Issue status update for http://drupal.org/node/28721 Post a follow up: http://drupal.org/project/comments/add/28721 Project: Drupal Version: cvs Component: upload.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: eafarris Updated by: killes@www.drop.org -Status: patch (code needs review) +Status: patch (ready to be committed) Tested, works, please apply. The current behaviour is highly annoying. killes@www.drop.org Previous comments: ------------------------------------------------------------------------ Thu, 11 Aug 2005 23:33:17 +0000 : eafarris Attachment: http://drupal.org/files/issues/upload.module_1.patch (1.21 KB) Simple patch that will expand the "File Attachments" form_group_collapsible() by default if there are files attached. ------------------------------------------------------------------------ Fri, 12 Aug 2005 18:57:11 +0000 : drumm I think <?php $has_attachments ? FALSE : TRUE ?> can be replaced with <?php !$has_attachments ?> ------------------------------------------------------------------------ Fri, 12 Aug 2005 21:07:56 +0000 : eafarris Attachment: http://drupal.org/files/issues/upload.module_2.patch (1.19 KB) Agreed. Here's an updated patch.
participants (3)
-
drumm -
eafarris -
killes