Project: Drupal Version: cvs Component: blog.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: tangent Updated by: Dries Status: patch This patch looks corrupts and contains HTML code. Dries Previous comments: ------------------------------------------------------------------------ January 22, 2005 - 23:49 : tangent Attachment: http://drupal.org/files/issues/blog.module.feedurl.patch (2.14 KB) The blog module creates user blog feed urls of the form "blog/feed/[UID]" while taxonomy follows the new url form of "taxonomy/term/1/1/feed". It seems that this should be changed to the new form of "blog/[UID]/feed" and the attached patch makes this change. Of course changing this will cause existing feed urls to become invalid so legacy.module is also patched to redirect old style urls. Legacy is modified as follows. "/blog/feed/52" will redirect to "/blog/52/feed" while "blog/feed" will not redirect -- View: http://drupal.org/node/16021 Edit: http://drupal.org/project/comments/add/16021

Project: Drupal Version: cvs Component: blog.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: tangent Updated by: tangent Status: patch RE the patch, it looks fine when I browse the link. It contains no markup, other than the already existing "link" tag which the patch modifies. Should I resubmit? RE url changes, I am not really familiar with legacy.module and only threw that change in at the last minute when contemplating how to deal with the url change. It is not clear to me what you're suggesting with update_97() so you'll have to explain or post an update yourself. tangent Previous comments: ------------------------------------------------------------------------ January 22, 2005 - 16:49 : tangent Attachment: http://drupal.org/files/issues/blog.module.feedurl.patch (2.14 KB) The blog module creates user blog feed urls of the form "blog/feed/[UID]" while taxonomy follows the new url form of "taxonomy/term/1/1/feed". It seems that this should be changed to the new form of "blog/[UID]/feed" and the attached patch makes this change. Of course changing this will cause existing feed urls to become invalid so legacy.module is also patched to redirect old style urls. Legacy is modified as follows. "/blog/feed/52" will redirect to "/blog/52/feed" while "blog/feed" will not redirect ------------------------------------------------------------------------ January 24, 2005 - 16:41 : Dries This patch looks corrupts and contains HTML code. ------------------------------------------------------------------------ January 24, 2005 - 17:02 : Steven Note that for URL changes, we should preferably add an update similar to update_97() and update_98(), which updated the URL aliases. Using an old alias will end you up in legacy.module, which does a drupal_goto() to a non-Clean url, which is not very desirable. -- View: http://drupal.org/node/16021 Edit: http://drupal.org/project/comments/add/16021

Project: Drupal Version: cvs Component: blog.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: tangent Updated by: tangent Status: patch Attachment: http://drupal.org/files/issues/updates.inc.blogfeedurl.patch (900 bytes) RE the url updates, after rereading and looking around a bit I've figured out what is being requested. I'm attaching a patch which adds update_120() which has the intention of updating url alias' for blog urls. I haven't tested it though. The original patch was changed to HTML somehow/somewhere that I cannot determine. Apologies. The second patch seems fine. tangent Previous comments: ------------------------------------------------------------------------ January 22, 2005 - 16:49 : tangent Attachment: http://drupal.org/files/issues/blog.module.feedurl.patch (2.14 KB) The blog module creates user blog feed urls of the form "blog/feed/[UID]" while taxonomy follows the new url form of "taxonomy/term/1/1/feed". It seems that this should be changed to the new form of "blog/[UID]/feed" and the attached patch makes this change. Of course changing this will cause existing feed urls to become invalid so legacy.module is also patched to redirect old style urls. Legacy is modified as follows. "/blog/feed/52" will redirect to "/blog/52/feed" while "blog/feed" will not redirect ------------------------------------------------------------------------ January 24, 2005 - 16:41 : Dries This patch looks corrupts and contains HTML code. ------------------------------------------------------------------------ January 24, 2005 - 17:02 : Steven Note that for URL changes, we should preferably add an update similar to update_97() and update_98(), which updated the URL aliases. Using an old alias will end you up in legacy.module, which does a drupal_goto() to a non-Clean url, which is not very desirable. ------------------------------------------------------------------------ January 24, 2005 - 17:10 : tangent RE the patch, it looks fine when I browse the link. It contains no markup, other than the already existing "link" tag which the patch modifies. Should I resubmit? RE url changes, I am not really familiar with legacy.module and only threw that change in at the last minute when contemplating how to deal with the url change. It is not clear to me what you're suggesting with update_97() so you'll have to explain or post an update yourself. ------------------------------------------------------------------------ January 24, 2005 - 17:27 : tangent Attachment: http://drupal.org/files/issues/blog_feedurl.patch (2.14 KB) Resubmitting same patch with a different filename (in case the problem is with the attachment system). -- View: http://drupal.org/node/16021 Edit: http://drupal.org/project/comments/add/16021

Project: Drupal Version: cvs Component: blog.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: tangent Updated by: tangent Status: patch Attachment: http://drupal.org/files/issues/updates.blogfeedurl.patch (900 bytes) I think I see a pattern. My second attachment does not include ".inc" in the filename while all other patches do. Saving the second file works as expected while the other attachments are being served up (and marked up apparently) as HTML. It looks like there is an issue with the project module or the file management code it relies on. Attaching the second patch again with no ".inc" in the filename to confirm my theory. tangent Previous comments: ------------------------------------------------------------------------ January 22, 2005 - 16:49 : tangent Attachment: http://drupal.org/files/issues/blog.module.feedurl.patch (2.14 KB) The blog module creates user blog feed urls of the form "blog/feed/[UID]" while taxonomy follows the new url form of "taxonomy/term/1/1/feed". It seems that this should be changed to the new form of "blog/[UID]/feed" and the attached patch makes this change. Of course changing this will cause existing feed urls to become invalid so legacy.module is also patched to redirect old style urls. Legacy is modified as follows. "/blog/feed/52" will redirect to "/blog/52/feed" while "blog/feed" will not redirect ------------------------------------------------------------------------ January 24, 2005 - 16:41 : Dries This patch looks corrupts and contains HTML code. ------------------------------------------------------------------------ January 24, 2005 - 17:02 : Steven Note that for URL changes, we should preferably add an update similar to update_97() and update_98(), which updated the URL aliases. Using an old alias will end you up in legacy.module, which does a drupal_goto() to a non-Clean url, which is not very desirable. ------------------------------------------------------------------------ January 24, 2005 - 17:10 : tangent RE the patch, it looks fine when I browse the link. It contains no markup, other than the already existing "link" tag which the patch modifies. Should I resubmit? RE url changes, I am not really familiar with legacy.module and only threw that change in at the last minute when contemplating how to deal with the url change. It is not clear to me what you're suggesting with update_97() so you'll have to explain or post an update yourself. ------------------------------------------------------------------------ January 24, 2005 - 17:27 : tangent Attachment: http://drupal.org/files/issues/blog_feedurl.patch (2.14 KB) Resubmitting same patch with a different filename (in case the problem is with the attachment system). ------------------------------------------------------------------------ January 24, 2005 - 23:07 : tangent Attachment: http://drupal.org/files/issues/updates.inc.blogfeedurl.patch (900 bytes) RE the url updates, after rereading and looking around a bit I've figured out what is being requested. I'm attaching a patch which adds update_120() which has the intention of updating url alias' for blog urls. I haven't tested it though. The original patch was changed to HTML somehow/somewhere that I cannot determine. Apologies. The second patch seems fine. ------------------------------------------------------------------------ January 24, 2005 - 23:11 : tangent Attachment: http://drupal.org/files/issues/updates.inc.blogfeedurl2.patch (900 bytes) The previous patch seems to have been converted to HTML as well though I've confirmed that my local file is definitely a plain patch. Did the file attachment system get hosed? Trying to attach it again. -- View: http://drupal.org/node/16021 Edit: http://drupal.org/project/comments/add/16021