Issue status update for http://drupal.org/node/28482 Post a follow up: http://drupal.org/project/comments/add/28482 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: Anonymous Reported by: Uwe Hermann Updated by: Dries Status: patch (code needs review) Committed to HEAD. Thanks. Dries Previous comments: ------------------------------------------------------------------------ Tue, 09 Aug 2005 01:28:01 +0000 : Uwe Hermann Attachment: http://drupal.org/files/issues/ids.patch (7.96 KB) Please add CVS $Id$ tags to all source files in Drupal core. This allows admins to know exactly which version of which files they use. In addition I want to use CVS $Id$ tags in my upcoming security.module to check for possible vulnerabilities. That's not possible if some files simply don't have $Id$s. Note: I also (mostly) unified the tags to use the "// ID" form instead of "/* ID */", but that's more of a cosmetic issue. I'm not sure whether *.txt files and the stuff in themes/ need tags(?)

Issue status update for http://drupal.org/node/28482 Post a follow up: http://drupal.org/project/comments/add/28482 Project: Drupal Version: 4.6.2 Component: base system Category: tasks Priority: normal Assigned to: Anonymous Reported by: Uwe Hermann Updated by: Dries -Status: patch (ready to be committed) +Status: patch (code needs work) The patch doesn't apply against 4.6. Dries Previous comments: ------------------------------------------------------------------------ Tue, 09 Aug 2005 01:28:01 +0000 : Uwe Hermann Attachment: http://drupal.org/files/issues/ids.patch (7.96 KB) Please add CVS $Id$ tags to all source files in Drupal core. This allows admins to know exactly which version of which files they use. In addition I want to use CVS $Id$ tags in my upcoming security.module to check for possible vulnerabilities. That's not possible if some files simply don't have $Id$s. Note: I also (mostly) unified the tags to use the "// ID" form instead of "/* ID */", but that's more of a cosmetic issue. I'm not sure whether *.txt files and the stuff in themes/ need tags(?) ------------------------------------------------------------------------ Thu, 11 Aug 2005 12:57:54 +0000 : Dries Committed to HEAD. Thanks. ------------------------------------------------------------------------ Thu, 11 Aug 2005 16:20:00 +0000 : Uwe Hermann Can you please apply the patch to 4.6, too? A potential 4.6.3 release should have the Id-tags, too. Uwe.

Issue status update for http://drupal.org/node/28482 Post a follow up: http://drupal.org/project/comments/add/28482 Project: Drupal Version: 4.6.2 Component: base system Category: tasks Priority: normal Assigned to: Anonymous Reported by: Uwe Hermann Updated by: Uwe Hermann Status: patch (ready to be committed) Attachment: http://drupal.org/files/issues/ids462.patch (6.02 KB) Oops, that was 4.6.0. Here's a patch for 4.6.2. Uwe Hermann Previous comments: ------------------------------------------------------------------------ Tue, 09 Aug 2005 01:28:01 +0000 : Uwe Hermann Attachment: http://drupal.org/files/issues/ids.patch (7.96 KB) Please add CVS $Id$ tags to all source files in Drupal core. This allows admins to know exactly which version of which files they use. In addition I want to use CVS $Id$ tags in my upcoming security.module to check for possible vulnerabilities. That's not possible if some files simply don't have $Id$s. Note: I also (mostly) unified the tags to use the "// ID" form instead of "/* ID */", but that's more of a cosmetic issue. I'm not sure whether *.txt files and the stuff in themes/ need tags(?) ------------------------------------------------------------------------ Thu, 11 Aug 2005 12:57:54 +0000 : Dries Committed to HEAD. Thanks. ------------------------------------------------------------------------ Thu, 11 Aug 2005 16:20:00 +0000 : Uwe Hermann Can you please apply the patch to 4.6, too? A potential 4.6.3 release should have the Id-tags, too. Uwe. ------------------------------------------------------------------------ Thu, 11 Aug 2005 17:26:57 +0000 : Dries The patch doesn't apply against 4.6. ------------------------------------------------------------------------ Fri, 12 Aug 2005 00:21:48 +0000 : Uwe Hermann Attachment: http://drupal.org/files/issues/ids46.patch (6.02 KB) Updated patch for 4.6.

Issue status update for http://drupal.org/node/28482 Post a follow up: http://drupal.org/project/comments/add/28482 Project: Drupal Version: 4.6.2 Component: base system Category: tasks Priority: normal Assigned to: Anonymous Reported by: Uwe Hermann Updated by: Uwe Hermann -Status: patch (code needs work) +Status: patch (ready to be committed) Attachment: http://drupal.org/files/issues/ids46_0.patch (2.56 KB) Updated patch (against DRUPAL-4-6). Uwe Hermann Previous comments: ------------------------------------------------------------------------ Tue, 09 Aug 2005 01:28:01 +0000 : Uwe Hermann Attachment: http://drupal.org/files/issues/ids.patch (7.96 KB) Please add CVS $Id$ tags to all source files in Drupal core. This allows admins to know exactly which version of which files they use. In addition I want to use CVS $Id$ tags in my upcoming security.module to check for possible vulnerabilities. That's not possible if some files simply don't have $Id$s. Note: I also (mostly) unified the tags to use the "// ID" form instead of "/* ID */", but that's more of a cosmetic issue. I'm not sure whether *.txt files and the stuff in themes/ need tags(?) ------------------------------------------------------------------------ Thu, 11 Aug 2005 12:57:54 +0000 : Dries Committed to HEAD. Thanks. ------------------------------------------------------------------------ Thu, 11 Aug 2005 16:20:00 +0000 : Uwe Hermann Can you please apply the patch to 4.6, too? A potential 4.6.3 release should have the Id-tags, too. Uwe. ------------------------------------------------------------------------ Thu, 11 Aug 2005 17:26:57 +0000 : Dries The patch doesn't apply against 4.6. ------------------------------------------------------------------------ Fri, 12 Aug 2005 00:21:48 +0000 : Uwe Hermann Attachment: http://drupal.org/files/issues/ids46.patch (6.02 KB) Updated patch for 4.6. ------------------------------------------------------------------------ Fri, 12 Aug 2005 21:42:43 +0000 : Uwe Hermann Attachment: http://drupal.org/files/issues/ids462.patch (6.02 KB) Oops, that was 4.6.0. Here's a patch for 4.6.2. ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:03:54 +0000 : Dries Committed to DRUPAL-4-6. Parts of the patch were rejected though so the code needs some more work. $ patch -p0 < ids462.patch patching file database/updates.inc Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file database/updates.inc.rej patching file includes/common.inc Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file includes/common.inc.rej patching file includes/file.inc patching file includes/menu.inc patching file includes/theme.inc patching file modules/aggregator.module Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file modules/aggregator.module.rej patching file modules/path.module patching file modules/upload.module patching file scripts/code-clean.sh patching file scripts/code-style.pl patching file scripts/cron-curl.sh patching file scripts/cron-lynx.sh patching file scripts/prefix.sh