[drupal-devel] forum.module dependent on comment.module
Hi! forum.module is dependent on comment.module in a very visible way on this line: $topic->new_replies = comment_num_new($topic->nid, $history); and in subtle ways, by SELECTing from node_comment_statistics which is INSERTed and UPDATEd in comment_nodeapi. First of all, this at least needs to be documented and also we need to describe how to have a site where users can not comment but can use forums. Second, we shall either change forum not be dependent on comment or we shall make a mechanism which makes sure that if forum is enabled then comment is enabled also. I do know that this could delay 4.6 but this is very confusing and there are several threads already on drupal.org about it. Regards NK
First of all, this at least needs to be documented and also we need to describe how to have a site where users can not comment but can use forums.
I don't see any value in a forum that disallows comments.
Second, we shall either change forum not be dependent on comment or we shall make a mechanism which makes sure that if forum is enabled then comment is enabled also. I do know that this could delay 4.6 but this is very confusing and there are several threads already on drupal.org about it.
Well, forum.module could throw an error on its settings a q=forum page if comment.module is disabled. thats how other modules handle dependencies at the moment. Vlado has talked of improving this.
Moshe Weitzman wrote:
First of all, this at least needs to be documented and also we need to describe how to have a site where users can not comment but can use forums.
I don't see any value in a forum that disallows comments.
I think the original comment was sugesting about a situation where comments /are/ wanted for the forum, but not for the other pages (it doesn't make sense to not have comments on the forum). Is it easy to change the default /page/ 'user comments' permission to 'disabled' instead of 'read/write'?
Ross Kendall wrote:
Moshe Weitzman wrote:
First of all, this at least needs to be documented and also we need to describe how to have a site where users can not comment but can use forums.
I don't see any value in a forum that disallows comments.
I think the original comment was sugesting about a situation where comments /are/ wanted for the forum, but not for the other pages (it doesn't make sense to not have comments on the forum).
Is it easy to change the default /page/ 'user comments' permission to 'disabled' instead of 'read/write'?
you can manage this on the default workflow page in admin/node => configure.
On Fri, 04 Mar 2005 09:38:12 -0500, Moshe Weitzman <weitzman@tejasa.com> wrote:
I don't see any value in a forum that disallows comments.
I think a better long term goal, for forum.module, is to eliminate dependance on comments altogether. When trying to integrate mailhandler and listhandler so that listserve messages are added as forum nodes it feels very strange and inappropriate to add some messages as nodes and others as comments. When I was working on this it seemed like there was more of a reason it should not be done but I don't remember now.
participants (4)
-
Chris Cook -
Moshe Weitzman -
Negyesi Karoly -
Ross Kendall