Issue status update for http://drupal.org/node/23310 Post a follow up: http://drupal.org/project/comments/add/23310 Project: Drupal Version: 4.6.0 Component: user.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: factoryjoe Updated by: factoryjoe Status: patch (code needs review) +1 for the solution and to graying out options. factoryjoe Previous comments: ------------------------------------------------------------------------ Fri, 20 May 2005 23:47:25 +0000 : factoryjoe Because you can enable/disable user pictures in the PHPTemplate config pages, that option should not exist under admin/users. And if PHPTemplate shouldn't handle this option, it should be removed from PHPTemplate's config screens. This option should be set in one place, and one place only. ------------------------------------------------------------------------ Wed, 01 Jun 2005 04:47:29 +0000 : Steven Attachment: http://drupal.org/files/issues/picture.patch (1.07 KB) I disagree... the option in admin/users controls whether users can upload a picture. This image is always displayed in their profile and this is a user.module feature. The PHPTemplate options on the other hand control whether pictures are displayed next to nodes resp. comments. This is a theme feature. The two are different and complement each other. Sometimes you may want users to have pictures, but not have them displayed next to each post. In that case you could even let users upload larger pictures of themselves as they don't need to fit snugly next to text. However you are partially right: it does not make sense to show the PHPTemplate options if user pictures are not allowed, so we should only make them appear in the right situation. I've attached a patch for this. ------------------------------------------------------------------------ Wed, 01 Jun 2005 04:53:47 +0000 : Steven Attachment: http://drupal.org/files/issues/picture_0.patch (1.22 KB) Ah, it seems we prefer to disable the toggles rather than hide them. It is probably for the best (I've always read you should disable options if they can be enabled by the user in this session). I had to generalize the check for search.module a bit, the code is cleaner now.