[drupal-devel] [bug] No q=poll breadcrumb; link to q=poll breadcrumb only present if block enabled
Issue status update for http://drupal.org/node/19485 Project: Drupal Version: cvs Component: poll.module Category: bug reports Priority: minor Assigned to: Anonymous Reported by: ankur Updated by: ankur Status: active I was looking at a bug report submitted on civicspacelabs.org (http://civicspacelabs.org/home/node/7185). The issue was about there being no breadcrumbs (there should be one: "Home") when you go to q=poll. I was looking through the code and noticed that there is no obvious way to get to q=poll unless the poll block is enabled. I was thinking both problems could be solved by changing poll_menu() so that it changes the path for q=poll to q=admin/poll....? Of course, I know that perms for q=admin/poll would then have to fall under the 'create polls' permission, which would then make it useless for the 'older polls' link in the polls block, but I'm thinking there's no harm done in making this a seperate menu item in poll_menu. If this is something that you think deserves a patch, I'm willing to submit one... -Ankur ankur
Issue status update for http://drupal.org/node/19485 Project: Drupal Version: cvs Component: poll.module Category: bug reports Priority: minor Assigned to: Anonymous Reported by: ankur Updated by: ankur Status: active sorry, the title should really read "....q=poll link only present if block enabled". ankur Previous comments: ------------------------------------------------------------------------ March 26, 2005 - 05:47 : ankur I was looking at a bug report submitted on civicspacelabs.org (http://civicspacelabs.org/home/node/7185). The issue was about there being no breadcrumbs (there should be one: "Home") when you go to q=poll. I was looking through the code and noticed that there is no obvious way to get to q=poll unless the poll block is enabled. I was thinking both problems could be solved by changing poll_menu() so that it changes the path for q=poll to q=admin/poll....? Of course, I know that perms for q=admin/poll would then have to fall under the 'create polls' permission, which would then make it useless for the 'older polls' link in the polls block, but I'm thinking there's no harm done in making this a seperate menu item in poll_menu. If this is something that you think deserves a patch, I'm willing to submit one... -Ankur
Issue status update for http://drupal.org/node/19485 Project: Drupal Version: cvs Component: poll.module Category: bug reports Priority: minor Assigned to: Anonymous Reported by: ankur Updated by: nysus Status: active Attachment: http://drupal.org/files/issues/poll_patch.patch (581 bytes) Here's a patch that adds "Home" to the q=poll page. nysus Previous comments: ------------------------------------------------------------------------ March 26, 2005 - 00:47 : ankur I was looking at a bug report submitted on civicspacelabs.org (http://civicspacelabs.org/home/node/7185). The issue was about there being no breadcrumbs (there should be one: "Home") when you go to q=poll. I was looking through the code and noticed that there is no obvious way to get to q=poll unless the poll block is enabled. I was thinking both problems could be solved by changing poll_menu() so that it changes the path for q=poll to q=admin/poll....? Of course, I know that perms for q=admin/poll would then have to fall under the 'create polls' permission, which would then make it useless for the 'older polls' link in the polls block, but I'm thinking there's no harm done in making this a seperate menu item in poll_menu. If this is something that you think deserves a patch, I'm willing to submit one... -Ankur ------------------------------------------------------------------------ March 26, 2005 - 00:50 : ankur sorry, the title should really read "....q=poll link only present if block enabled".
Issue status update for http://drupal.org/node/19485 Project: Drupal Version: cvs Component: poll.module Category: bug reports Priority: minor Assigned to: Anonymous Reported by: ankur Updated by: Steven Status: patch If there is no easy way to get to the polls list, perhaps a suggested menu item should be added. Steven Previous comments: ------------------------------------------------------------------------ March 26, 2005 - 06:47 : ankur I was looking at a bug report submitted on civicspacelabs.org (http://civicspacelabs.org/home/node/7185). The issue was about there being no breadcrumbs (there should be one: "Home") when you go to q=poll. I was looking through the code and noticed that there is no obvious way to get to q=poll unless the poll block is enabled. I was thinking both problems could be solved by changing poll_menu() so that it changes the path for q=poll to q=admin/poll....? Of course, I know that perms for q=admin/poll would then have to fall under the 'create polls' permission, which would then make it useless for the 'older polls' link in the polls block, but I'm thinking there's no harm done in making this a seperate menu item in poll_menu. If this is something that you think deserves a patch, I'm willing to submit one... -Ankur ------------------------------------------------------------------------ March 26, 2005 - 06:50 : ankur sorry, the title should really read "....q=poll link only present if block enabled". ------------------------------------------------------------------------ March 27, 2005 - 18:14 : nysus Attachment: http://drupal.org/files/issues/poll_patch.patch (581 bytes) Here's a patch that adds "Home" to the q=poll page.
participants (3)
-
ankur -
nysus -
Steven