Issue status update for http://drupal.org/node/23210 Project: Drupal Version: cvs Component: theme system Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: Thox Status: patch +1 for sure. Backwards compatible /and/ makes FactoryJoe happy. Thox Previous comments: ------------------------------------------------------------------------ May 19, 2005 - 19:12 : chx Attachment: http://drupal.org/files/issues/theme_settings_0.patch (913 bytes) End the endless debates and provide a theme overrideable hook for include misc/drupal.css. The idea (partially) comes from FactoryJoe.

Issue status update for http://drupal.org/node/23210 Project: Drupal Version: cvs Component: theme system Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: kbahey Status: patch +1. Each side can have it their way. Those who want drupal.css to stay can now focus the discussion on improving it, and not "to be or not to be" arguments. kbahey Previous comments: ------------------------------------------------------------------------ May 19, 2005 - 14:12 : chx Attachment: http://drupal.org/files/issues/theme_settings_0.patch (913 bytes) End the endless debates and provide a theme overrideable hook for include misc/drupal.css. The idea (partially) comes from FactoryJoe. ------------------------------------------------------------------------ May 19, 2005 - 14:19 : Thox +1 for sure. Backwards compatible /and/ makes FactoryJoe happy. ------------------------------------------------------------------------ May 19, 2005 - 14:23 : factoryjoe Hey if it makes me happy, how can I not +1? So this is the logic of this patch, to quell the whole drupal.css controversy once and for all... Since themes can override themable functions, I proposed doing something similarly drupally for the drupal.css issue. Basically if a theme provides its own drupal.css, it should use that to override the default. If the theme doesn't, then the usual 'misc/drupal.css' file is linked. CHX implemented this solution in 10 seconds and seems to accomplish both protecting the backwards compatibility of themes that reply on drupal.css while giving wacky themers like myself the ability to override drupal.css completely. Nice. +1.

Issue status update for http://drupal.org/node/23210 Project: Drupal Version: cvs Component: theme system Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: Dries Status: patch Why? It is already possible to overwrite the stylesheet. This looks like cruft to me. Dries Previous comments: ------------------------------------------------------------------------ May 19, 2005 - 21:12 : chx Attachment: http://drupal.org/files/issues/theme_settings_0.patch (913 bytes) End the endless debates and provide a theme overrideable hook for include misc/drupal.css. The idea (partially) comes from FactoryJoe. ------------------------------------------------------------------------ May 19, 2005 - 21:19 : Thox +1 for sure. Backwards compatible /and/ makes FactoryJoe happy. ------------------------------------------------------------------------ May 19, 2005 - 21:23 : factoryjoe Hey if it makes me happy, how can I not +1? So this is the logic of this patch, to quell the whole drupal.css controversy once and for all... Since themes can override themable functions, I proposed doing something similarly drupally for the drupal.css issue. Basically if a theme provides its own drupal.css, it should use that to override the default. If the theme doesn't, then the usual 'misc/drupal.css' file is linked. CHX implemented this solution in 10 seconds and seems to accomplish both protecting the backwards compatibility of themes that reply on drupal.css while giving wacky themers like myself the ability to override drupal.css completely. Nice. +1. ------------------------------------------------------------------------ May 19, 2005 - 21:27 : kbahey +1. Each side can have it their way. Those who want drupal.css to stay can now focus the discussion on improving it, and not "to be or not to be" arguments. ------------------------------------------------------------------------ May 19, 2005 - 21:27 : Bèr Kessels Why can't factoryjoe override theme('stylesheet_import', 'misc/drupal.css'); ? Allright, it needs a little logic to pass all other stylesheets, but not 'misc/drupal.css', but that is as hard as a sinle if statement. +1 on Making Chris happy. -1 on this patch :)