Fwd: [jQuery] Re: Birthday is coming
Does jQuery time is releases by when Drupal has theirs? :-) Seriously though, jQuery 1.2.2 is supposed to be just a bug-fix release. Given that we're in RC status, should we be upgrading as well, to keep the bug count down, or avoiding it because OMG that would be changing code in an RC? Or put more pragmatically... Were someone to write a 1.2.2 patch for Drupal 6, would it be considered? ---------- Forwarded Message ---------- Subject: [jQuery] Re: Birthday is coming Date: Friday 11 January 2008 From: "John Resig" <jeresig@gmail.com> To: jquery-en@googlegroups.com Yep - that's the current plan! --John On Jan 11, 2008 11:12 AM, Cloudream <cloudream@gmail.com> wrote:
is 1.22 going to be release on Jan,14? Seems lots of bugs were fixed.
------------------------------------------------------- -- Larry Garfield AIM: LOLG42 larry@garfieldtech.com ICQ: 6817012 "If nature has made any one thing less susceptible than all others of exclusive property, it is the action of the thinking power called an idea, which an individual may exclusively possess as long as he keeps it to himself; but the moment it is divulged, it forces itself into the possession of every one, and the receiver cannot dispossess himself of it." -- Thomas Jefferson
On 1/11/08, Larry Garfield <larry@garfieldtech.com> wrote:
Seriously though, jQuery 1.2.2 is supposed to be just a bug-fix release. Given that we're in RC status, should we be upgrading as well, to keep the bug count down, or avoiding it because OMG that would be changing code in an RC?
Or put more pragmatically... Were someone to write a 1.2.2 patch for Drupal 6, would it be considered?
Yes ... Further I think that a pure bug fix release of Jquery is acceptable even after 6 goes out. We wouldn't rush out a release just for that, but i expect such a patch would be accepted.
On Jan 12, 2008 5:55 AM, Moshe Weitzman <weitzman@tejasa.com> wrote:
On 1/11/08, Larry Garfield <larry@garfieldtech.com> wrote:
Seriously though, jQuery 1.2.2 is supposed to be just a bug-fix release. Given that we're in RC status, should we be upgrading as well, to keep the bug count down, or avoiding it because OMG that would be changing code in an RC?
Or put more pragmatically... Were someone to write a 1.2.2 patch for Drupal 6, would it be considered?
Yes ... Further I think that a pure bug fix release of Jquery is acceptable even after 6 goes out. We wouldn't rush out a release just for that, but i expect such a patch would be accepted.
IMHO we should consider on the grounds of Drupal functionality. Such a patch would need all JS functionality tested in "all" browsers (== the browsers people tested previous JS functionality in). Gabor
yes, all the usual rules for a drupal patch apply - don't break anything in any browser. this is indeed a more onerous test for jquery upgrade that a php patch. but once the tests are passed, i think the patch is committable. my .02 On 1/13/08, Gábor Hojtsy <gabor@hojtsy.hu> wrote:
On Jan 12, 2008 5:55 AM, Moshe Weitzman <weitzman@tejasa.com> wrote:
On 1/11/08, Larry Garfield <larry@garfieldtech.com> wrote:
Seriously though, jQuery 1.2.2 is supposed to be just a bug-fix release. Given that we're in RC status, should we be upgrading as well, to keep the bug count down, or avoiding it because OMG that would be changing code in an RC?
Or put more pragmatically... Were someone to write a 1.2.2 patch for Drupal 6, would it be considered?
Yes ... Further I think that a pure bug fix release of Jquery is acceptable even after 6 goes out. We wouldn't rush out a release just for that, but i expect such a patch would be accepted.
IMHO we should consider on the grounds of Drupal functionality. Such a patch would need all JS functionality tested in "all" browsers (== the browsers people tested previous JS functionality in).
Gabor
On 1/14/08, Moshe Weitzman <weitzman@tejasa.com> wrote:
yes, all the usual rules for a drupal patch apply - don't break anything in any browser. this is indeed a more onerous test for jquery upgrade that a php patch. but once the tests are passed, i think the patch is committable. my .02
Could these tests be automated with simpletest and/or selenium? I expect many of them require visual review that the UI hasn't changed negatively. Could this be partially automated with a screenshot-based framework? A system like selenium does the clicks and form-completion, then takes screenshots of patched and unpatched test sites and compares the images, and/or queues them for human review. What about interactive pages with JS-based motion (like slowly collapsing and expanding fieldsets. Could the above be applied to a video screencast? Does such a framework exist? Such tests could make testing and QA of future jQuery upgrades so much easier. Bevan/ -- Drupal.geek.nz | Gtalk bevan@lucion.co.nz | YIM rudgy_m_nz | .Mac/AOL b.rudge | skype b.rudge | Twitter.com/BevanR
Moshe Weitzman wrote:
yes, all the usual rules for a drupal patch apply - don't break anything in any browser. this is indeed a more onerous test for jquery upgrade that a php patch. but once the tests are passed, i think the patch is committable. my .02
List of tests to try at http://groups.drupal.org/node/5974 (see the JAVASCRIPT section). The sooner a patch is rolled, the sooner people can start running these in all major browsers. -Angie
participants (5)
-
Angela Byron -
Bevan Rudge -
Gábor Hojtsy -
Larry Garfield -
Moshe Weitzman