normally i wouldn't post request for feedback on an issue here, but this is a sweeping change, and it needs eyes on it! Deletion API for core: The deletion API will provide a standardized method through which deletions from the database can be managed more completely. It offers several hooks, both prior to deletion, which allow outside modules to display messages on a confirmation screen, process the data prior to deletion, or abort deletion altogether. the issue: http://drupal.org/node/126300 a very kick ass demo site, with theory, workflow, links to the code that makes it work, and it also serves as a test site for checking out what it can do as of today: http://deleteapi.xcarnated.com hunmonk
http://drupal.org/user/19502 Commits to diff, views, panels, google analytics...
On 10 Mar 2007, at 1:51 AM, Robert Douglass wrote:
Commits to diff, views, panels, google analytics... Well. that's thomas of wikifonia.
Not sure how he got commit access on all those projects, but he is probably using them all on that project. He doesn't appear on the cvs access list for at least one of those i checked (views bonus pack). Is the access check perhaps broken ?
adrian rossouw wrote:
On 10 Mar 2007, at 1:51 AM, Robert Douglass wrote:
Commits to diff, views, panels, google analytics...
Well. that's thomas of wikifonia.
Not sure how he got commit access on all those projects, but he is probably using them all on that project. He doesn't appear on the cvs access list for at least one of those i checked (views bonus pack).
Is the access check perhaps broken ?
Once I had a mixed up commit, where my commit has been attributed to someone else who didn't have access to the project. The other person had committed at the same time. It might be worth checking the source of the actual commit in CVS.
On Mar 9, 2007, at 4:24 PM, sime wrote:
Once I had a mixed up commit, where my commit has been attributed to someone else who didn't have access to the project. The other person had committed at the same time.
yeah, for a while i've suspected that the scripts which integrate CVS with Drupal (know as "xcvs*") aren't transaction safe and could contain race conditions, etc. they certainly don't use any of drupal's DB-abstraction layer, they're just raw mysql calls in php. i never really had a chance to look through this aspect of them carefully, i just tacked the access control stuff on top of what was already there. however, i probably should do so now, since, as the size of our contributor community grows, if there's a race, it's more and more likely we're hitting it... -derek
On Saturday 10 March 2007 07:51, Robert Douglass wrote:
Commits to diff, views, panels, google analytics...
One of each: Wouldn't those be translation commits? Anyone can commit translation anywhere... A. -- http://www.wechange.org/ Because we and the world need to change. http://www.reuniting.info/ Intimate Relationships, peace and harmony in the couple.
Hi, Does it mean I can commit po files to any published projects? Is it a good/common practice or submitting to issue queue is still preferred? I have a bunch of po's I'd like to contribute...if committing directly is acceptable it'd be much easier for me. Thanks. -Jim On 3/10/07, Augustin (Beginner) <drupal.beginner@wechange.org> wrote:
On Saturday 10 March 2007 07:51, Robert Douglass wrote:
Commits to diff, views, panels, google analytics...
One of each: Wouldn't those be translation commits? Anyone can commit translation anywhere...
A.
-- http://www.wechange.org/ Because we and the world need to change.
http://www.reuniting.info/ Intimate Relationships, peace and harmony in the couple.
Jim Li wrote:
Hi, Does it mean I can commit po files to any published projects?
Yes, currently. We want to change that though and make translations their own projects.
Is it a good/common practice or submitting to issue queue is still preferred? I have a bunch of po's I'd like to contribute...if committing directly is acceptable it'd be much easier for me.
I guess that depends on the author of the module, so I'd advise asking. I'd accept that you interpret "no answer" (in maybe a week) as "yes, you may commit". Cheers, Gerhard
Robert Douglass wrote:
Commits to diff, views, panels, google analytics...
He sent me an apology; he was doing an import and he doesn't know how those commit messages were generated. No code was harmed in the filming of this event.
participants (9)
-
adrian rossouw -
Augustin (Beginner) -
Chad Phillips -- Apartment Lines -
Derek Wright -
Earl Miles -
Gerhard Killesreiter -
Jim Li -
Robert Douglass -
sime