Since we are talking themes, establishing a minimum criteria for "certifying" themes as Drupal 5 or 6 compatible would be really helpful for module developers who rely on things I thought would be core to any theme... like print $scripts. I'm seeing an increasing number of issues in the TinyMCE queue from users who have downloaded themes that don't include print $scripts. I don't know if I'm just getting these because TinyMCE is the first module these people are trying that requires javascript, but I actually had a user suggest that we include the print $scripts requirement in the TinyMCE documentation!?! http://drupal.org/node/126297 http://drupal.org/node/133457 I'm going to include reverting to a default theme in a "things to try before asking" post, but the quality of some of the contributed themes is really spotty. I did not follow up to figure out which themes they were using because I really didn't have time to do anything about it, but I did recommend they post an issue for the theme. Testing themes for few basics like print $scripts, php declarations on all tags, etc would be something folks new to Drupal could do to contribute. I'd actually be willing to put a series of tests together and get this started if there was a way to share the data with users. I'm not interested in making subjective decisions about what looks good... only that the theme has all the pieces to function and play nice with that version of Drupal. - Kevin Reynen On 4/23/07, Dries Buytaert <dries.buytaert@gmail.com> wrote:

Hello world,

I'd like to invite/encourage you to help test and review the following issues:

http://drupal.org/node/137211 http://drupal.org/node/137236

It would be great to get them in shape before Earl goes (or might go) absent for a while!

So, could we give them some prime quality attention? If would be great to get this of our plate, so we can start focusing on other parts of Drupal. What's needed are some careful reviews and testing reports. Thanks!

-- Dries Buytaert :: http://www.buytaert.net/

Dries Buytaert wrote:

Hello world,

I'd like to invite/encourage you to help test and review the following issues:

http://drupal.org/node/137236

This patch has been committed! Rejoice! This is a very, very serious patch for all developers, because it lets you take that extra step toward truly separating your logic from your presentation in a way that Drupal has tried to do in the past but been a little bit awkward. Every module developer is going to need to be aware of this patch in order to truly make the most out of Drupal 6 theming. It's going to need some serious documenting, too, because it rewrites all the documents about how template engines work and how modules and themes utilize theming functions.

http://drupal.org/node/137211

This patch still needs testing -- I just rerolled it for HEAD, and now would be an excellent time. I'm going to disappear Monday evening for awhile (the baby is overdue and we're inducing Monday if she doesn't come over the weekend) and this could really use some quality testing while I'm around to make tweaks. This patch is particularly important for a couple of reasons: 1) It'll remove reliance on 'page.tpl.php' for a theme to be a phptemplate theme; it'll give more transparency into what a theme really is by looking at the .info file (because the engine will be specified there. No guessing!) 2) You will be able to have true inheritance of themes with no directory hierarchy requirements. This means that the appropriate way to tweak a theme will be not to edit that theme at all, but to make a new theme, inherit the original theme, and then put in your new templates and stylesheet modifications; this will make it easier to keep your theme up to date as the author posts new releases. It will also make it easier for your site to have more sub-themes that are just tweaks of existing themes. And this theme hierarchy can be multi-level, too.