Re: [drupal-devel] [drupal:unconed] /includes common.inc /modules forum.module taxonomy.module
On 07 May 2005, at 03:48, drupal-devel@drupal.org wrote:
User: unconed Branch: HEAD Date: Sat, 07 May 2005 01:48:06 +0000
Modified files: /includes common.inc /modules forum.module taxonomy.module
Log message: - #19621: More sensible status messages for forum admin ("created forum" instead of "created term").
Links:
http://cvs.drupal.org/diff.php?path=drupal/includes/ common.inc&old=1.439&new=1.440
http://cvs.drupal.org/diff.php?path=drupal/modules/ forum.module&old=1.251&new=1.252
http://cvs.drupal.org/diff.php?path=drupal/modules/ taxonomy.module&old=1.199&new=1.200
Can't we rename these to STATUS_* or something? SAVED_* (eg. SAVED_DELETED) looks weird to me. (It's the reason I hadn't committed this patch yet.) -- Dries Buytaert :: http://www.buytaert.net/
On Sat, May 07, 2005 at 09:19:05AM +0200, Dries Buytaert wrote:
On 07 May 2005, at 03:48, drupal-devel@drupal.org wrote:
User: unconed Branch: HEAD Date: Sat, 07 May 2005 01:48:06 +0000 Log message: - #19621: More sensible status messages for forum admin ("created forum" instead of "created term").
Can't we rename these to STATUS_* or something? SAVED_* (eg. SAVED_DELETED) looks weird to me. (It's the reason I hadn't committed this patch yet.)
I'm okay with either wording. It should probably be decided on soon in case anyone was thinking of going through Drupal core and looking for every function that does something and sets its own status message. (I was thinking about that, but I don't have much spare time this week.)
participants (2)
-
Dries Buytaert -
neil＠civicspacelabs.org