Issue status update for http://drupal.org/node/27822 Post a follow up: http://drupal.org/project/comments/add/27822 Project: Drupal Version: cvs Component: contact.module Category: feature requests Priority: minor Assigned to: Anonymous Reported by: Tobias Maier Updated by: Tobias Maier Status: patch this is just one step of my work they saied "make many small patches" and this is what I do... you got an email with a patch which does what you want Tobias Maier Previous comments: ------------------------------------------------------------------------ Sat, 30 Jul 2005 01:17:33 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/contact_nochoise.patch (1.18 KB) if you have just one Subject the Subject field is not shown because you have no choice to select another subject. it is also possible to show its name. but this patch hides it hope you like it ------------------------------------------------------------------------ Sat, 30 Jul 2005 09:59:26 +0000 : kbahey I prefer that we not use the subject at all this way. What should be a drop down list must be topic/category, and subject must be manually entered by each user. For example, category can be "drupal.org web site problem" and subject can be "cannot post a project" or "bad formatting of wide pages".

Issue status update for http://drupal.org/node/27822 Post a follow up: http://drupal.org/project/comments/add/27822 Project: Drupal Version: cvs Component: contact.module Category: feature requests Priority: minor Assigned to: Anonymous Reported by: Tobias Maier Updated by: Tobias Maier Status: patch now you can forget this patch and apply directly this one merging feedback.module into contact.module [1] it has much more improvements and bugfixes [1] http://drupal.org/node/27633 Tobias Maier Previous comments: ------------------------------------------------------------------------ Sat, 30 Jul 2005 01:17:33 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/contact_nochoise.patch (1.18 KB) if you have just one Subject the Subject field is not shown because you have no choice to select another subject. it is also possible to show its name. but this patch hides it hope you like it ------------------------------------------------------------------------ Sat, 30 Jul 2005 09:59:26 +0000 : kbahey I prefer that we not use the subject at all this way. What should be a drop down list must be topic/category, and subject must be manually entered by each user. For example, category can be "drupal.org web site problem" and subject can be "cannot post a project" or "bad formatting of wide pages". ------------------------------------------------------------------------ Sat, 30 Jul 2005 10:36:43 +0000 : Tobias Maier this is just one step of my work they saied "make many small patches" and this is what I do... you got an email with a patch which does what you want ------------------------------------------------------------------------ Sat, 30 Jul 2005 12:11:12 +0000 : kbahey But, if you are to do it the right way later, it will overwrite that fix that you just provided a patch for. It will also create more load on others (review patchs, apply patches, ...etc. will happen twice). So, for patches, do provide many small patches (which are easier to understand and review) , but do not make them cancel each other or change what a previous patch did.