[drupal-devel] [task] Remove hard coded HTML for comment moderation
Issue status update for http://drupal.org/node/20103 Project: Drupal Version: cvs Component: comment.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/comment.module_8.diff (5.34 KB) Removing another place where we have hard coded HTML instead of the form functions. The unpublish selection actually didn't seem to work, so I removed it since we have delete. It should be implemented as a link anyway. drumm
I'm thinking of +1'ing this, but I'm not sure I get it completely. If it removes hardcoded HTML, +1. Hopefully this is separate from the moderation option discussion Neil and I had offline. Also, I need to be able to hide the comment moderation buttons in my print styles, so they need to be classed. I think this patch does this, yes/no? Chris On Apr 6, 2005 5:02 PM, drumm <drupal-devel@drupal.org> wrote:
Issue status update for http://drupal.org/node/20103
Project: Drupal Version: cvs Component: comment.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/comment.module_8.diff (5.34 KB)
Removing another place where we have hard coded HTML instead of the form functions. The unpublish selection actually didn't seem to work, so I removed it since we have delete. It should be implemented as a link anyway.
drumm
On Wed, Apr 06, 2005 at 05:15:22PM -0700, Chris Messina wrote:
I'm thinking of +1'ing this, but I'm not sure I get it completely. If it removes hardcoded HTML, +1. Hopefully this is separate from the moderation option discussion Neil and I had offline.
Also, I need to be able to hide the comment moderation buttons in my print styles, so they need to be classed. I think this patch does this, yes/no?
I actually used an id for the button itself, there is only one of them. And the class for the dropdown would be .comment .links .form-item. -Neil
Issue status update for http://drupal.org/node/20103 Project: Drupal Version: cvs Component: comment.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: Dries Status: patch Committed to HEAD. Thanks. Dries Previous comments: ------------------------------------------------------------------------ April 7, 2005 - 01:17 : drumm Attachment: http://drupal.org/files/issues/comment.module_8.diff (5.34 KB) Removing another place where we have hard coded HTML instead of the form functions. The unpublish selection actually didn't seem to work, so I removed it since we have delete. It should be implemented as a link anyway.
Issue status update for http://drupal.org/node/20103 Project: Drupal Version: cvs Component: comment.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm -Status: closed +Status: patch Attachment: http://drupal.org/files/issues/comment.module_9.diff (976 bytes) One last wording change. drumm Previous comments: ------------------------------------------------------------------------ April 6, 2005 - 17:17 : drumm Attachment: http://drupal.org/files/issues/comment.module_8.diff (5.34 KB) Removing another place where we have hard coded HTML instead of the form functions. The unpublish selection actually didn't seem to work, so I removed it since we have delete. It should be implemented as a link anyway. ------------------------------------------------------------------------ April 6, 2005 - 23:24 : Dries Committed to HEAD. Thanks.
Issue status update for http://drupal.org/node/20103 Project: Drupal Version: cvs Component: comment.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: Dries Status: patch Committed to HEAD and DRUPAL-4-6. Thanks. Dries Previous comments: ------------------------------------------------------------------------ April 7, 2005 - 01:17 : drumm Attachment: http://drupal.org/files/issues/comment.module_8.diff (5.34 KB) Removing another place where we have hard coded HTML instead of the form functions. The unpublish selection actually didn't seem to work, so I removed it since we have delete. It should be implemented as a link anyway. ------------------------------------------------------------------------ April 7, 2005 - 07:24 : Dries Committed to HEAD. Thanks. ------------------------------------------------------------------------ April 7, 2005 - 20:34 : drumm Attachment: http://drupal.org/files/issues/comment.module_9.diff (976 bytes) One last wording change.
participants (4)
-
Chris Messina -
Dries -
drumm
-
neil＠civicspacelabs.org