[drupal-devel] [bug] Menu system requires a local task to have more than 1 child in order to create secondary local tasks
Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: andremolnar Updated by: andremolnar Status: patch Attachment: http://drupal.org/files/issues/menu_inc_1a.patch (826 bytes) This is a minor bug. The menu system requires a local task to have more than 1 child in order to create secondary local tasks. In other words if a local task only had 1 child, menu system would not create a secondary local task menu item. This patch fixes that with the addition of 1 character in the code. andre andremolnar -- View: http://drupal.org/node/17022 Edit: http://drupal.org/project/comments/add/17022
Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: andremolnar Updated by: Dries Status: patch I'm pretty sure this patch would break some pages. Some modules have a tab and a subtab that show the same page. The tracker page, for example, relies on the fact that the subtab does not get shown when there is only one subtab. However, when there are two or more subtabs, they are being visualized. I guess this needs some more thought. Dries Previous comments: ------------------------------------------------------------------------ February 8, 2005 - 23:49 : andremolnar Attachment: http://drupal.org/files/issues/menu_inc_1a.patch (826 bytes) This is a minor bug. The menu system requires a local task to have more than 1 child in order to create secondary local tasks. In other words if a local task only had 1 child, menu system would not create a secondary local task menu item. This patch fixes that with the addition of 1 character in the code. andre -- View: http://drupal.org/node/17022 Edit: http://drupal.org/project/comments/add/17022
Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: andremolnar Updated by: andremolnar Status: patch hmmm... Well, I certainly don't think that this should be the expected behaviour of the menu system. A child menu item is a child menu item, and I would expect that it show up if I create that child in hook_menu. When patching user.module it took me over half an hour to track down this bug (a single missing character was easy to over look). Nor do I personally think that the menu system should accomodate exceptions of the sort described in tracker.module. It should be the module's job to decide when to create a local task in hook_menu using logic local to the module. IMHO if applying this 'breaks' modules - so be it. It would force a necissary code/logic improvement in those modules. andre andremolnar Previous comments: ------------------------------------------------------------------------ February 8, 2005 - 21:49 : andremolnar Attachment: http://drupal.org/files/issues/menu_inc_1a.patch (826 bytes) This is a minor bug. The menu system requires a local task to have more than 1 child in order to create secondary local tasks. In other words if a local task only had 1 child, menu system would not create a secondary local task menu item. This patch fixes that with the addition of 1 character in the code. andre ------------------------------------------------------------------------ February 8, 2005 - 22:52 : Dries I'm pretty sure this patch would break some pages. Some modules have a tab and a subtab that show the same page. The tracker page, for example, relies on the fact that the subtab does not get shown when there is only one subtab. However, when there are two or more subtabs, they are being visualized. I guess this needs some more thought. -- View: http://drupal.org/node/17022 Edit: http://drupal.org/project/comments/add/17022
Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: andremolnar Updated by: Dries Status: patch Well, the problem is that the tracker module can't determine whether to add the subtask. It should only be added when another module adds a second subtask. I'll explore this some more. Dries Previous comments: ------------------------------------------------------------------------ February 8, 2005 - 23:49 : andremolnar Attachment: http://drupal.org/files/issues/menu_inc_1a.patch (826 bytes) This is a minor bug. The menu system requires a local task to have more than 1 child in order to create secondary local tasks. In other words if a local task only had 1 child, menu system would not create a secondary local task menu item. This patch fixes that with the addition of 1 character in the code. andre ------------------------------------------------------------------------ February 9, 2005 - 00:52 : Dries I'm pretty sure this patch would break some pages. Some modules have a tab and a subtab that show the same page. The tracker page, for example, relies on the fact that the subtab does not get shown when there is only one subtab. However, when there are two or more subtabs, they are being visualized. I guess this needs some more thought. ------------------------------------------------------------------------ February 9, 2005 - 01:18 : andremolnar hmmm... Well, I certainly don't think that this should be the expected behaviour of the menu system. A child menu item is a child menu item, and I would expect that it show up if I create that child in hook_menu. When patching user.module it took me over half an hour to track down this bug (a single missing character was easy to over look). Nor do I personally think that the menu system should accomodate exceptions of the sort described in tracker.module. It should be the module's job to decide when to create a local task in hook_menu using logic local to the module. IMHO if applying this 'breaks' modules - so be it. It would force a necissary code/logic improvement in those modules. andre -- View: http://drupal.org/node/17022 Edit: http://drupal.org/project/comments/add/17022
Issue status update for http://drupal.org/node/17022 Post a follow up: http://drupal.org/project/comments/add/17022 Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: andremolnar Updated by: killes@www.drop.org -Status: active +Status: patch (code needs work) There is a patch after all. killes@www.drop.org Previous comments: ------------------------------------------------------------------------ Tue, 08 Feb 2005 21:49:34 +0000 : andremolnar Attachment: http://drupal.org/files/issues/menu_inc_1a.patch (826 bytes) This is a minor bug. The menu system requires a local task to have more than 1 child in order to create secondary local tasks. In other words if a local task only had 1 child, menu system would not create a secondary local task menu item. This patch fixes that with the addition of 1 character in the code. andre ------------------------------------------------------------------------ Tue, 08 Feb 2005 22:52:09 +0000 : Dries I'm pretty sure this patch would break some pages. Some modules have a tab and a subtab that show the same page. The tracker page, for example, relies on the fact that the subtab does not get shown when there is only one subtab. However, when there are two or more subtabs, they are being visualized. I guess this needs some more thought. ------------------------------------------------------------------------ Tue, 08 Feb 2005 23:18:25 +0000 : andremolnar hmmm... Well, I certainly don't think that this should be the expected behaviour of the menu system. A child menu item is a child menu item, and I would expect that it show up if I create that child in hook_menu. When patching user.module it took me over half an hour to track down this bug (a single missing character was easy to over look). Nor do I personally think that the menu system should accomodate exceptions of the sort described in tracker.module. It should be the module's job to decide when to create a local task in hook_menu using logic local to the module. IMHO if applying this 'breaks' modules - so be it. It would force a necissary code/logic improvement in those modules. andre ------------------------------------------------------------------------ Wed, 09 Feb 2005 06:18:42 +0000 : Dries Well, the problem is that the tracker module can't determine whether to add the subtask. It should only be added when another module adds a second subtask. I'll explore this some more. ------------------------------------------------------------------------ Sun, 13 Mar 2005 18:55:26 +0000 : killes@www.drop.org Dries doesn't like it as is.
Issue status update for http://drupal.org/node/17022 Post a follow up: http://drupal.org/project/comments/add/17022 Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: andremolnar Updated by: drumm Status: patch (code needs work) -1 There are quite a few cases where the current behavior is desirable. Modules often add local tasks to pages which were not made by the module itself. This is helps the end UI to not resemble the underlying modular structure. The current de-facto standard is that a local task's title should not be necessary to the page if it is the only local task by default and should provide distinction from potential additional local tasks. What is the user.module problem which led to this issue? drumm Previous comments: ------------------------------------------------------------------------ Tue, 08 Feb 2005 21:49:34 +0000 : andremolnar Attachment: http://drupal.org/files/issues/menu_inc_1a.patch (826 bytes) This is a minor bug. The menu system requires a local task to have more than 1 child in order to create secondary local tasks. In other words if a local task only had 1 child, menu system would not create a secondary local task menu item. This patch fixes that with the addition of 1 character in the code. andre ------------------------------------------------------------------------ Tue, 08 Feb 2005 22:52:09 +0000 : Dries I'm pretty sure this patch would break some pages. Some modules have a tab and a subtab that show the same page. The tracker page, for example, relies on the fact that the subtab does not get shown when there is only one subtab. However, when there are two or more subtabs, they are being visualized. I guess this needs some more thought. ------------------------------------------------------------------------ Tue, 08 Feb 2005 23:18:25 +0000 : andremolnar hmmm... Well, I certainly don't think that this should be the expected behaviour of the menu system. A child menu item is a child menu item, and I would expect that it show up if I create that child in hook_menu. When patching user.module it took me over half an hour to track down this bug (a single missing character was easy to over look). Nor do I personally think that the menu system should accomodate exceptions of the sort described in tracker.module. It should be the module's job to decide when to create a local task in hook_menu using logic local to the module. IMHO if applying this 'breaks' modules - so be it. It would force a necissary code/logic improvement in those modules. andre ------------------------------------------------------------------------ Wed, 09 Feb 2005 06:18:42 +0000 : Dries Well, the problem is that the tracker module can't determine whether to add the subtask. It should only be added when another module adds a second subtask. I'll explore this some more. ------------------------------------------------------------------------ Sun, 13 Mar 2005 18:55:26 +0000 : killes@www.drop.org Dries doesn't like it as is. ------------------------------------------------------------------------ Wed, 10 Aug 2005 17:19:03 +0000 : killes@www.drop.org There is a patch after all.
participants (4)
-
andremolnar -
Dries
-
drumm
-
killes