[drupal-devel] [bug] Inaccurate Temp Directory Description
Issue status update for http://drupal.org/node/26778 Post a follow up: http://drupal.org/project/comments/add/26778 Project: Drupal -Version: 4.6.2 +Version: cvs Component: system.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Alex Reisner Updated by: Uwe Hermann -Status: active +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/tmp_path.patch (2.09 KB) Here's a patch for HEAD which fixes the documentation. Not sure whether the docs or the code should be fixed. Comments? Uwe Hermann Previous comments: ------------------------------------------------------------------------ Fri, 15 Jul 2005 16:18:44 +0000 : Alex Reisner On the admin/settings page the help text for the Temporary Directory field reads: "Location where uploaded files will be kept during previews. Relative paths will be resolved relative to the file system path." However, this does not seem to be the case. Just above the code which generates this message (system.module line 237) the temp directory is checked as relative to the site root. Similar interpretation is found in file_create_path($dest) (file.inc line 52): // check if the destination is instead inside the Drupal temporary files directory. else if (file_check_location($dest, variable_get('file_directory_temp', FILE_DIRECTORY_TEMP))) { return $dest; I believe the code in both places works as it should; the help text on this field should be revised to something like: "Location where uploaded files will be kept during previews. Relative paths are interpreted from the Drupal installation directory."
participants (1)
-
Uwe Hermann