[drupal-devel] [feature] Move submission guidelines and minimum word count to node module.
Project: Drupal Version: cvs Component: node system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/move_submission_things.diff (7.8 KB) Screenshot at http://foo.delocalizedham.com/tmp/1.png (rejected screenshot is http://foo.delocalizedham.com/tmp/2.png). This moves the submission guidelines found in forum, story, and blog and the minimum number of words found in story and blog (blog had a slight bug) into the node module. This makes a total of 2 less settings pages. I added a todo for counting words in languages which don't have the concept of spaces as the western languages. Here is what Steven said about that when I asked: 15:06 < UnConeD> drumm: word counting doesn't scale well though 15:06 < UnConeD> to different languages i mean 15:06 < UnConeD> there's just no good way to do it Also, the $type variable passed to node_types_configure wasn't being set so the whole content types admin actually wasn't working. That is fixed too. drumm -- View: http://drupal.org/node/16192 Edit: http://drupal.org/project/comments/add/16192
Project: Drupal Version: cvs Component: node system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/move_submission_things_0.diff (10.88 KB) And here is a patchfile of the right files. drumm Previous comments: ------------------------------------------------------------------------ January 25, 2005 - 17:56 : drumm Attachment: http://drupal.org/files/issues/move_submission_things.diff (7.8 KB) Screenshot at http://foo.delocalizedham.com/tmp/1.png (rejected screenshot is http://foo.delocalizedham.com/tmp/2.png). This moves the submission guidelines found in forum, story, and blog and the minimum number of words found in story and blog (blog had a slight bug) into the node module. This makes a total of 2 less settings pages. I added a todo for counting words in languages which don't have the concept of spaces as the western languages. Here is what Steven said about that when I asked: 15:06 < UnConeD> drumm: word counting doesn't scale well though 15:06 < UnConeD> to different languages i mean 15:06 < UnConeD> there's just no good way to do it Also, the $type variable passed to node_types_configure wasn't being set so the whole content types admin actually wasn't working. That is fixed too. -- View: http://drupal.org/node/16192 Edit: http://drupal.org/project/comments/add/16192
Project: Drupal Version: cvs Component: node system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: Dries Status: patch Looks good to me! Dries Previous comments: ------------------------------------------------------------------------ January 26, 2005 - 01:56 : drumm Attachment: http://drupal.org/files/issues/move_submission_things.diff (7.8 KB) Screenshot at http://foo.delocalizedham.com/tmp/1.png (rejected screenshot is http://foo.delocalizedham.com/tmp/2.png). This moves the submission guidelines found in forum, story, and blog and the minimum number of words found in story and blog (blog had a slight bug) into the node module. This makes a total of 2 less settings pages. I added a todo for counting words in languages which don't have the concept of spaces as the western languages. Here is what Steven said about that when I asked: 15:06 < UnConeD> drumm: word counting doesn't scale well though 15:06 < UnConeD> to different languages i mean 15:06 < UnConeD> there's just no good way to do it Also, the $type variable passed to node_types_configure wasn't being set so the whole content types admin actually wasn't working. That is fixed too. ------------------------------------------------------------------------ January 26, 2005 - 02:14 : drumm Attachment: http://drupal.org/files/issues/move_submission_things_0.diff (10.88 KB) And here is a patchfile of the right files. -- View: http://drupal.org/node/16192 Edit: http://drupal.org/project/comments/add/16192
Project: Drupal Version: cvs Component: node system Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: Goba Status: patch These efforts are quickly depreciating modules like story and page, leaving no code in them :) Seems like at least the 'clone the node' feature will be disireable in core, since leaving the story module in there after this patch is nonsense. Goba Previous comments: ------------------------------------------------------------------------ January 26, 2005 - 00:56 : drumm Attachment: http://drupal.org/files/issues/move_submission_things.diff (7.8 KB) Screenshot at http://foo.delocalizedham.com/tmp/1.png (rejected screenshot is http://foo.delocalizedham.com/tmp/2.png). This moves the submission guidelines found in forum, story, and blog and the minimum number of words found in story and blog (blog had a slight bug) into the node module. This makes a total of 2 less settings pages. I added a todo for counting words in languages which don't have the concept of spaces as the western languages. Here is what Steven said about that when I asked: 15:06 < UnConeD> drumm: word counting doesn't scale well though 15:06 < UnConeD> to different languages i mean 15:06 < UnConeD> there's just no good way to do it Also, the $type variable passed to node_types_configure wasn't being set so the whole content types admin actually wasn't working. That is fixed too. ------------------------------------------------------------------------ January 26, 2005 - 01:14 : drumm Attachment: http://drupal.org/files/issues/move_submission_things_0.diff (10.88 KB) And here is a patchfile of the right files. ------------------------------------------------------------------------ January 26, 2005 - 10:44 : Dries Looks good to me! -- View: http://drupal.org/node/16192 Edit: http://drupal.org/project/comments/add/16192
participants (3)
-
Dries -
drumm -
Goba