[drupal-devel] [bug] Menu.inc error when running on php5
Issue status update for http://drupal.org/node/27582 Post a follow up: http://drupal.org/project/comments/add/27582 Project: Drupal Version: 4.6.2 Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: iraszl Updated by: iraszl Status: patch In *menu.inc*, function menu_execute_active_handler() I changed: if (strlen($arg)) { To: if (strlen($arg) && is_array($arguments)) { That did the trick to get rid of the annoying error messages in the log. iraszl
Issue status update for http://drupal.org/node/27582 Post a follow up: http://drupal.org/project/comments/add/27582 Project: Drupal Version: 4.6.2 Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: iraszl Updated by: Uwe Hermann -Status: active +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/menu_19.patch (732 bytes) Here's a patch (untested). Uwe Hermann Previous comments: ------------------------------------------------------------------------ Wed, 27 Jul 2005 10:05:24 +0000 : iraszl In *menu.inc*, function menu_execute_active_handler() I changed: if (strlen($arg)) { To: if (strlen($arg) && is_array($arguments)) { That did the trick to get rid of the annoying error messages in the log. ------------------------------------------------------------------------ Sun, 07 Aug 2005 01:32:39 +0000 : killes@www.drop.org not a patch
Issue status update for http://drupal.org/node/27582 Post a follow up: http://drupal.org/project/comments/add/27582 Project: Drupal Version: 4.6.2 Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: iraszl Updated by: killes@www.drop.org Status: patch (code needs review) Attachment: http://drupal.org/files/issues/callback.patch (2.05 KB) According to http://drupaldocs.org/api/head/function/hook_menu the callback arguments need to be an array. The only occurrence in core that needs to be changed is in commment module, patch attached. There are several contrib modules that need patching, though. I've updated the docs for menu.inc a bit. killes@www.drop.org Previous comments: ------------------------------------------------------------------------ Wed, 27 Jul 2005 10:05:24 +0000 : iraszl In *menu.inc*, function menu_execute_active_handler() I changed: if (strlen($arg)) { To: if (strlen($arg) && is_array($arguments)) { That did the trick to get rid of the annoying error messages in the log. ------------------------------------------------------------------------ Sun, 07 Aug 2005 01:32:39 +0000 : killes@www.drop.org not a patch ------------------------------------------------------------------------ Sun, 21 Aug 2005 19:32:15 +0000 : Uwe Hermann Attachment: http://drupal.org/files/issues/menu_19.patch (732 bytes) Here's a patch (untested).
participants (3)
-
iraszl -
killes -
Uwe Hermann