[drupal-devel] [bug] Bootstrap patch fixes
Issue status update for http://drupal.org/node/25600 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: critical Assigned to: chx Reported by: kubaZygmunt Updated by: walkah Status: patch just to follow up.. chx's patch in #7 only fixes XMLRPC servers... anything that uses XML-RPC client (i.e. drupal_auth or ping) will still be busted. walkah Previous comments: ------------------------------------------------------------------------ June 23, 2005 - 06:28 : kubaZygmunt Attachment: http://drupal.org/files/issues/bootstrap.diff (422 bytes) I've found that new cvs version doesn't get properly db_prefix. In bootstrap.inc (function _drupal_bootstrap($phase) ) I added another global variable $db_prefix, and then it goes . I don't know if my solution is good because on my local site I can't see any blocks and on my internet site I have some caching and I can't see anything :) ------------------------------------------------------------------------ June 23, 2005 - 07:45 : kubaZygmunt Above I've put my patch ------------------------------------------------------------------------ June 23, 2005 - 07:56 : Jaza Attachment: http://drupal.org/files/issues/db_prefix_global.patch (582 bytes) Also noticed this bug, when trying to install a fresh CVS snapshot. Attached is my patch against CVS HEAD (same as kubaZygmunt's, basically). ------------------------------------------------------------------------ June 23, 2005 - 08:10 : chx Yes, this is a bug, if you look at the bootstrap patch, there were versions when I thought variables in settings.php should be written as $GLOBALS['something'] but then introduced global $something . Forgot when that something is db_prefix . ------------------------------------------------------------------------ June 28, 2005 - 00:26 : Jaza Can this patch be applied to HEAD please? This is not something that should be left sitting around in the issues list. Chx has identified that it was a simple honest mistake on his part, and has indicated that the submitted patch(es) will fix the mistake. Until this patch is applied, anyone who tries to install HEAD using db prefixes will get a fatal error. It doesn't get much more critical than that :-p. ------------------------------------------------------------------------ June 30, 2005 - 09:56 : Bart Jansens Attachment: http://drupal.org/files/issues/20050630.bootstrap-prefix-update.patch (1.21 KB) There is another related problem, it is no longer possible to override variables in settings.php. And update.php no longer works. Updated patch attached. ------------------------------------------------------------------------ June 30, 2005 - 10:04 : chx Attachment: http://drupal.org/files/issues/20050630.bootstrap-patch.patch (2.92 KB) Oh, and XML-RPC client is broken too. I talked with walkah and we found it the best to move xmlrpc.inc to modules which use them. ------------------------------------------------------------------------ June 30, 2005 - 10:09 : chx Attachment: http://drupal.org/files/issues/20050630.1.bootstrap-patch.patch (3.34 KB) some more xml-rpc fixes. ------------------------------------------------------------------------ June 30, 2005 - 10:20 : Steven Making XML-RPC a conditional include was discussed a while ago, and decided against due to problems with the class persistency. Why is this now possible? ------------------------------------------------------------------------ June 30, 2005 - 12:36 : walkah basically - it's not. the problem is, well, the xmlrpc.inc is not very well written. It requires / depends on several global variables, etc. which leads to a fair bit of the scoping issues. If you look at what PEAR has done with this (since their XML-RPC module is based on the same original code)... you'll notice lots of $GLOBALS['...'] usage (see http://cvs.php.net/co.php/pear/XML_RPC/RPC.php) . Basically, I think we have 3 options: 1) keep banging on this old code to make it work. 2) switch libraries to either PEAR::XML-RPC or something like incutio's (http://scripts.incutio.com/xmlrpc/) 3) re-write our own custom xml-rpc library personally, I'd +1 #2 - since #1 is ugly, and #3 I personally don't have time for, and I'd rather see our developer resources going to more interesting things. that said, i know there are those with strong feelings against 3rd party libraries... but this needs to get fixed quickly. blogapi and drupal dist_auth are both currently broken in HEAD. (isn't there anyone else here that tests XML-RPC stuff??)
Hi all, I wanted to let you all know how the Summer of Code money we get will be used, in case you were wondering. Since we will be eligible for up to $5,500.00 this is a good opportunity to do some nice things. First we will be sponsoring a theme competition with a $1000 first prize and a $500 second prize. I'll announce this on Drupal.org in the next week or so but you can already start thinking in the back of your minds what technical requirements new themes need to meet in order to be accepted and how we can easily verify these things. The rest of the money (all of which is dependent on the students completing their projects) will be used to fund Drupal development and each of the mentors will be given discretion to a) describe a project and b) take on the work himself if he cares to and c) name a developer to do the work otherwise. Read my next mail for details on the first project that has already been decided. cheers, Robert
On 30-Jun-05, at 11:07 AM, Robert Douglass wrote:
I wanted to let you all know how the Summer of Code money we get will be used, in case you were wondering. Since we will be eligible for up to $5,500.00 this is a good opportunity to do some nice things.
First we will be sponsoring a theme competition with a $1000 first prize and a $500 second prize. I'll announce this on Drupal.org in the next week or so but you can already start thinking in the back of your minds what technical requirements new themes need to meet in order to be accepted and how we can easily verify these things.
A chunk of this money should be reserved for setting up a foundation (s?). I'm going to look at the requirements for this in Canada in the next couple of days with a lawyer. -- Boris Mann http://www.bmannconsulting.com
Actually, if this can be done relatively quickly (before September) it would simplify the task of accepting Google's money. I think a fundraiser would also be appropriate for paying for the incorporating fees for a foundation. -Robert
A chunk of this money should be reserved for setting up a foundation (s?). I'm going to look at the requirements for this in Canada in the next couple of days with a lawyer.
-- Boris Mann http://www.bmannconsulting.com
A chunk of this money should be reserved for setting up a foundation (s?).
Very wise idea.
I'm going to look at the requirements for this in Canada in the next couple of days with a lawyer.
Will that provide for US tax-deduction? Someone look around for EU, please. I did contacted a tax lawyer monthes ago for the Hungarian possibilites (for those who really do not care about the worrld: we ARE EU now for more than a year), and the red tape amount is suffocating.
On Thu, 30 Jun 2005, Karoly Negyesi wrote:
A chunk of this money should be reserved for setting up a foundation (s?).
Very wise idea.
I'm going to look at the requirements for this in Canada in the next couple of days with a lawyer.
Will that provide for US tax-deduction?
No, of course it won't. Countries give tax deductions to further some causes (welfare, whatever). Why should the US taxpayer give tax deductions to Canadian good causes?
Someone look around for EU, please.
Just the same: If I set up a non-profit in .de I won't be able to issue tax deduction to people from .fr. Well, in fact I might be able too, but they would only help if the person pays taxes in .de. Cheers, Gerhard
IANAL, but the US generally requires tax-deductible donations go to 503(c) (a tax code) non-profit corporations and get a receipt from the organization to prove your donation. I say "generally" because even if your taxes were audited, auditors are overworked people, who usually don't take their jobs seriously enough to harass someone over a $100 donation to any organization with "foundation" in the name, especially if you can produce a receipt. They're usually just happy if you show up with any documentation at all. To them that's a sign you at least intended to do the "right thing". Auditors are people, too. Gerhard Killesreiter wrote:
No, of course it won't. Countries give tax deductions to further some causes (welfare, whatever). Why should the US taxpayer give tax deductions to Canadian good causes?
David Norman wrote:
IANAL, but the US generally requires tax-deductible donations go to 503(c) (a tax code) non-profit corporations and get a receipt from the organization to prove your donation.
Actually, there are several classes of tax-deductible organizations in the US tax code. The most common is the 501(c)3 charity, but there are others. Donations under a certain amount ($75 in 2004) never need a receipt. Donations to "qualified organizations" appear to also not need a receipt, but there may be a much higher level or other catch. Donations for which there is no benefits (e.g. membership, magazine subscription, etc.) also appear not to need receipts. Most likely a Drupal foundation could become a qualified organization. Note also that US tax code allows deductions contributed by US taxpayers to some Canadian charities (IRS Publication 597), Mexican charities (special rules) and Israeli charities (special rules). See IRS Publication 526 for a brief mention. Mostly these are not useful unless you have income from Canada, Mexico or Israel. I am not a tax lawyer or accountant, either -- but I am the president of a non-profit and have done taxes for myself and businesses I owned in the past, and have to approve the tax forms for the non-profit each year. It's complicated stuff, but not impossible to do by laymen. Probably the amount of paperwork and bureaucracy is similar in all countries. Governments don't like giving up tax revenue in general. :-) I think it's worth creating such a foundation for Drupal, though, despite the hurdles. -- Chris Johnson
Someone look around for EU, please. I did contacted a tax lawyer monthes ago for the Hungarian possibilites (for those who really do not care about the worrld: we ARE EU now for more than a year), and the red tape amount is suffocating. Red tape in EU is least in UK, but everyone is taxed in their country of residense. I don't think you can get a EU-wide charity or equivalent status, but I might be wrong.
Grehards, you are quite right about " Man soll das fell desBaeren nicht verteilen, befor man ihn hat" Vlado
On Thu, 30 Jun 2005, Boris Mann wrote:
On 30-Jun-05, at 11:07 AM, Robert Douglass wrote:
I wanted to let you all know how the Summer of Code money we get will be used, in case you were wondering. Since we will be eligible for up to $5,500.00 this is a good opportunity to do some nice things.
First we will be sponsoring a theme competition with a $1000 first prize and a $500 second prize. I'll announce this on Drupal.org in the next week or so but you can already start thinking in the back of your minds what technical requirements new themes need to meet in order to be accepted and how we can easily verify these things.
A chunk of this money should be reserved for setting up a foundation (s?). I'm going to look at the requirements for this in Canada in the next couple of days with a lawyer.
Wrong way round, I think. Setting up some foundation or other institution might be a prerequisite to get the money at all. German saying: Man soll das fell desBaeren nicht verteilen, befor man ihn hat. Cheers, Gerhard
Drupal Summer of Code mentor Károly Négyesi (aka chx) has stepped up with his idea for a project to be sponsored with SoC money and has volunteered to implement it. He will research the field to find a replacement for our current XML-RPC library and write the necessary patches to fix HEAD with regards to XML-RPC. $1,000 of the money we receive at the end of the Summer from Google will be reserved to pay him for this effort. Thanks Károly and thanks Google! -Robert
On Thursday 30 June 2005 20:11, Robert Douglass wrote:
Drupal Summer of Code mentor Károly Négyesi (aka chx) has stepped up with his idea for a project to be sponsored with SoC money and has volunteered to implement it.
To clear up some issues: a) I intend to start with Incutio's XML-RPC b) I contacted the author already and he is fine with GPL'ing the result c) the result will be quite a bit different from the original, 'cos I'll make it use procedural notation and overall, more Drupalish. Regards NK
participants (8)
-
Boris Mann -
Chris Johnson -
David Norman -
Gerhard Killesreiter -
Karoly Negyesi -
Robert Douglass -
vlado -
walkah