Project: Drupal Version: cvs Component: other Category: feature requests Priority: minor Assigned to: Anonymous Reported by: Jeremy@kerneltrap.org Updated by: Bèr Kessels Status: patch great! +1 from me. But, the three dots (...) are still not thmeabnle, nor have they got a style. The arent even wrapped in a HTML element. IMO that we sthe worst thing of the current pager: that i could do nothing with these dots. :) Bèr Kessels Previous comments: ------------------------------------------------------------------------ January 27, 2005 - 05:30 : Jeremy@kerneltrap.org Attachment: http://drupal.org/files/issues/pager.inc_1.patch (8.65 KB) Is there anything gained from making the pager.inc pager pieces themeable? I'm no longer sure, but the attached patch does so. -- View: http://drupal.org/node/16273 Edit: http://drupal.org/project/comments/add/16273

Project: Drupal Version: cvs Component: other Category: feature requests Priority: minor Assigned to: Anonymous Reported by: Jeremy@kerneltrap.org Updated by: tangent Status: patch Wrapping them in a div is only marginally better for theming purposes without assigning a class. tangent Previous comments: ------------------------------------------------------------------------ January 26, 2005 - 23:30 : Jeremy@kerneltrap.org Attachment: http://drupal.org/files/issues/pager.inc_1.patch (8.65 KB) Is there anything gained from making the pager.inc pager pieces themeable? I'm no longer sure, but the attached patch does so. ------------------------------------------------------------------------ January 27, 2005 - 09:13 : Bèr Kessels great! +1 from me. But, the three dots (...) are still not thmeabnle, nor have they got a style. The arent even wrapped in a HTML element. IMO that we sthe worst thing of the current pager: that i could do nothing with these dots. :) ------------------------------------------------------------------------ January 27, 2005 - 09:24 : Jeremy@kerneltrap.org Attachment: http://drupal.org/files/issues/pager.inc_2.patch (8.63 KB) Is it sufficient to wrap them in div? See attached. -- View: http://drupal.org/node/16273 Edit: http://drupal.org/project/comments/add/16273

Project: Drupal Version: cvs Component: other Category: feature requests Priority: minor Assigned to: Anonymous Reported by: Jeremy@kerneltrap.org Updated by: Jeremy@kerneltrap.org Status: patch Attachment: http://drupal.org/files/issues/pager.inc_4.patch (3.54 KB) Here's the proper followup patch. Jeremy@kerneltrap.org Previous comments: ------------------------------------------------------------------------ January 26, 2005 - 23:30 : Jeremy@kerneltrap.org Attachment: http://drupal.org/files/issues/pager.inc_1.patch (8.65 KB) Is there anything gained from making the pager.inc pager pieces themeable? I'm no longer sure, but the attached patch does so. ------------------------------------------------------------------------ January 27, 2005 - 09:13 : Bèr Kessels great! +1 from me. But, the three dots (...) are still not thmeabnle, nor have they got a style. The arent even wrapped in a HTML element. IMO that we sthe worst thing of the current pager: that i could do nothing with these dots. :) ------------------------------------------------------------------------ January 27, 2005 - 09:24 : Jeremy@kerneltrap.org Attachment: http://drupal.org/files/issues/pager.inc_2.patch (8.63 KB) Is it sufficient to wrap them in div? See attached. ------------------------------------------------------------------------ January 27, 2005 - 09:28 : tangent Wrapping them in a div is only marginally better for theming purposes without assigning a class. ------------------------------------------------------------------------ January 27, 2005 - 09:32 : Dries Committed to HEAD. ------------------------------------------------------------------------ January 27, 2005 - 10:48 : Jeremy@kerneltrap.org Attachment: http://drupal.org/files/issues/pager.inc_3.patch (8.85 KB) Here's a followup patch to add classes to each of the pager pieces, and the "...". -- View: http://drupal.org/node/16273 Edit: http://drupal.org/project/comments/add/16273

Project: Drupal Version: cvs Component: other Category: feature requests Priority: minor Assigned to: Anonymous Reported by: Jeremy@kerneltrap.org Updated by: Goba -Status: fixed +Status: patch Dries committed the patch without the closed quotes! Goba Previous comments: ------------------------------------------------------------------------ January 27, 2005 - 05:30 : Jeremy@kerneltrap.org Attachment: http://drupal.org/files/issues/pager.inc_1.patch (8.65 KB) Is there anything gained from making the pager.inc pager pieces themeable? I'm no longer sure, but the attached patch does so. ------------------------------------------------------------------------ January 27, 2005 - 15:13 : Bèr Kessels great! +1 from me. But, the three dots (...) are still not thmeabnle, nor have they got a style. The arent even wrapped in a HTML element. IMO that we sthe worst thing of the current pager: that i could do nothing with these dots. :) ------------------------------------------------------------------------ January 27, 2005 - 15:24 : Jeremy@kerneltrap.org Attachment: http://drupal.org/files/issues/pager.inc_2.patch (8.63 KB) Is it sufficient to wrap them in div? See attached. ------------------------------------------------------------------------ January 27, 2005 - 15:28 : tangent Wrapping them in a div is only marginally better for theming purposes without assigning a class. ------------------------------------------------------------------------ January 27, 2005 - 15:32 : Dries Committed to HEAD. ------------------------------------------------------------------------ January 27, 2005 - 16:48 : Jeremy@kerneltrap.org Attachment: http://drupal.org/files/issues/pager.inc_3.patch (8.85 KB) Here's a followup patch to add classes to each of the pager pieces, and the "...". ------------------------------------------------------------------------ January 27, 2005 - 16:49 : Jeremy@kerneltrap.org Attachment: http://drupal.org/files/issues/pager.inc_4.patch (3.54 KB) Here's the proper followup patch. ------------------------------------------------------------------------ January 27, 2005 - 16:52 : Jeremy@kerneltrap.org Attachment: http://drupal.org/files/issues/pager.inc_5.patch (3.54 KB) Sorry for the shotgun effect, but rumor has it you should close quotes. One more patch attached. ------------------------------------------------------------------------ January 27, 2005 - 16:54 : Dries Committed to HEAD. -- View: http://drupal.org/node/16273 Edit: http://drupal.org/project/comments/add/16273