Re: [drupal-devel] Re: [CS dev] Worth a look: Symphony
I would actually love to see this committed. Super easy to work with and perform maintenance. Would be a nice dev feature to make note of, simple enough for people who know what they are doing and need something like this. +1 for inclusion ted
On 9/29/05, Dries Buytaert <dries@buytaert.net> wrote:
To give you a quick idea, here is how my modified index.php looks like:
$maintenance = FALSE;
require_once './includes/bootstrap.inc'; drupal_bootstrap(DRUPAL_BOOTSTRAP_FULL);
if ($maintenance && $user->uid != 1) { drupal_set_title("We'll be right back"); print theme('maintenance_page', 'Drupal.org is being upgraded. We should be back in a jiffy.');
Dries http://drupal.org/node/32622 I was working on something similar for this, but a bit more elaborate, allowing a customized message on the front page, as well as an on/off setting. Only drawback is as mentioned: you can lock yourself out.
On 9/29/05, Dries Buytaert <dries@buytaert.net> wrote:
To give you a quick idea, here is how my modified index.php looks like:
$maintenance = FALSE;
require_once './includes/bootstrap.inc'; drupal_bootstrap(DRUPAL_BOOTSTRAP_FULL);
if ($maintenance && $user->uid != 1) { drupal_set_title("We'll be right back"); print theme('maintenance_page', 'Drupal.org is being upgraded. We should be back in a jiffy.');
On 30 Sep 2005, at 00:33, Khalid B wrote:
I was working on something similar for this, but a bit more elaborate, allowing a customized message on the front page, as well as an on/off setting.
Only drawback is as mentioned: you can lock yourself out.
Looks better than my approach, although your code needs to be updated to adhere the Drupal coding style. Some strings can't be translated either; missing t() functions. -- Dries Buytaert :: http://www.buytaert.net/
On Friday 30 September 2005 07:18, Dries Buytaert wrote:
On 30 Sep 2005, at 00:33, Khalid B wrote:
I was working on something similar for this, but a bit more elaborate, allowing a customized message on the front page, as well as an on/off setting.
Only drawback is as mentioned: you can lock yourself out.
Looks better than my approach, although your code needs to be updated to adhere the Drupal coding style. Some strings can't be translated either; missing t() functions.
Though both ideas look good, I (just like Gerhard) Am very interested in the performance penalty of an extra If on EVERY page. A benchmark, should IMO in this case be done over a long time. The performance penalty is, imo not worth the gain. But i'd like to see if my concerns are worth investigating at all. Bèr
On Fri, 30 Sep 2005, [iso-8859-1] Bèr Kessels wrote:
On Friday 30 September 2005 07:18, Dries Buytaert wrote:
On 30 Sep 2005, at 00:33, Khalid B wrote:
I was working on something similar for this, but a bit more elaborate, allowing a customized message on the front page, as well as an on/off setting.
Only drawback is as mentioned: you can lock yourself out.
Looks better than my approach, although your code needs to be updated to adhere the Drupal coding style. Some strings can't be translated either; missing t() functions.
Though both ideas look good, I (just like Gerhard) Am very interested in the performance penalty of an extra If on EVERY page. A benchmark, should IMO in this case be done over a long time. The performance penalty is, imo not worth the gain. But i'd like to see if my concerns are worth investigating at all.
I don't think the impact of a single if() would be measurable without a lot of effort. Cheers, Gerhard
Dries/Ber/Moshe/Gerhard Can you please comment in the issue, so we do not lose track of these discussions? The email subject is still Worth a look: Symphony. Here it is again http://drupal.org/node/32622 On 9/30/05, Gerhard Killesreiter <killesreiter@physik.uni-freiburg.de> wrote:
On Fri, 30 Sep 2005, [iso-8859-1] Bèr Kessels wrote:
On Friday 30 September 2005 07:18, Dries Buytaert wrote:
On 30 Sep 2005, at 00:33, Khalid B wrote:
I was working on something similar for this, but a bit more elaborate, allowing a customized message on the front page, as well as an on/off setting.
Only drawback is as mentioned: you can lock yourself out.
Looks better than my approach, although your code needs to be updated to adhere the Drupal coding style. Some strings can't be translated either; missing t() functions.
Though both ideas look good, I (just like Gerhard) Am very interested in the performance penalty of an extra If on EVERY page. A benchmark, should IMO in this case be done over a long time. The performance penalty is, imo not worth the gain. But i'd like to see if my concerns are worth investigating at all.
I don't think the impact of a single if() would be measurable without a lot of effort.
Cheers, Gerhard
participants (5)
-
Bèr Kessels -
Dries Buytaert -
Gerhard Killesreiter -
Khalid B -
Theodore Serbinski