From drupal-devel@drupal.org Wed Aug 31 18:37:30 2005
From: drupal-devel@drupal.org
To: drupal-cvs@drupal.org
Subject: [drupal:dries] /misc progress.gif progress.js upload.js /includes
	common.inc /misc autocomplete.js drupal.css drupal.js	/modules upload.module
Date: Wed, 31 Aug 2005 18:37:30 +0000
Message-ID: <20050831183730.30483.qmail@zind.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5881146364340306847=="

--===============5881146364340306847==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

User: dries	Branch: HEAD	Date: Wed, 31 Aug 2005 18:37:30 +0000

Added files:
  /misc progress.gif progress.js upload.js

Modified files:
  /includes common.inc
  /misc autocomplete.js drupal.css drupal.js
  /modules upload.module

Log message:
  - Patch #28483 by Steven: JavaScript enabled uploading.
 =20
    Comment from Steven: It does this by redirecting the submission of the fo=
rm to a hidden <iframe> when you click "Attach" (we cannot submit data throug=
h Ajax directly because you cannot read file contents from JS for security re=
asons).  Once the file is submitted, the upload-section of the form is update=
d.  Things to note:
 =20
      * The feature degrades back to the current behaviour without JS.
      * If there are errors with the uploaded file (disallowed type, too big,=
 ...), they are displayed at the top of the file attachments fieldset.
      * Though the hidden-iframe method sounds dirty, it's quite compact and =
is 100% implemented in .js files. The drupal.js api makes it a snap to use.
      * I included some minor improvements to the Drupal JS API and code.
      * I added an API drupal_call_js() to bridge the PHP/JS gap: it takes a =
function name and arguments, and outputs a <script> tag. The kicker is that i=
t preserves the structure and type of arguments, so e.g. PHP associative arra=
ys end up as objects in JS.
      * I also included a progressbar widget that I wrote for drumm's ongoing=
 update.php work. It includes Ajax status updating/monitoring, but it is only=
 used as a pure throbber in this patch. But as the code was already written a=
nd is going to be used in the near future, I left that part in. It's pretty s=
mall ;). If PHP supports ad-hoc upload info in the future like Ruby on Rails,=
 we can implement that in 5 minutes.

Links:
  http://cvs.drupal.org/diff.php?path=3Ddrupal/misc/progress.gif&old=3DNONE&n=
ew=3D1.1
  http://cvs.drupal.org/diff.php?path=3Ddrupal/misc/progress.js&old=3DNONE&ne=
w=3D1.1
  http://cvs.drupal.org/diff.php?path=3Ddrupal/misc/upload.js&old=3DNONE&new=
=3D1.1
  http://cvs.drupal.org/diff.php?path=3Ddrupal/includes/common.inc&old=3D1.47=
5&new=3D1.476
  http://cvs.drupal.org/diff.php?path=3Ddrupal/misc/autocomplete.js&old=3D1.4=
&new=3D1.5
  http://cvs.drupal.org/diff.php?path=3Ddrupal/misc/drupal.css&old=3D1.114&ne=
w=3D1.115
  http://cvs.drupal.org/diff.php?path=3Ddrupal/misc/drupal.js&old=3D1.6&new=
=3D1.7
  http://cvs.drupal.org/diff.php?path=3Ddrupal/modules/upload.module&old=3D1.=
49&new=3D1.50


--===============5881146364340306847==--