User: sdboyer Branch: HEAD Date: Fri, 19 Nov 2010 17:13:36 +0000 Modified files: /modules/versioncontrol/includes VersioncontrolAccount.php VersioncontrolBranch.php VersioncontrolItem.php VersioncontrolOperation.php VersioncontrolRepository.php VersioncontrolTag.php controllers.inc /modules/versioncontrol versioncontrol.pages.inc /modules/versioncontrol/versioncontrol_account_status versioncontrol_account_status.module /modules/versioncontrol/versioncontrol_fakevcs/includes classes.inc Log message: Issue #879858 by sdboyer and marvil07: unify all VersioncontrolEntity CRUD. Squashed commit of the following: commit e76ad66dbb92ae39294271ee20c468fa3f3f1917 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 19 09:11:02 2010 -0800 Reintroduce VersioncontrolOperation::updateLabels. commit 864ea5827fb2fd8c454b52fddf8cc1452521ed3d Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 19 09:10:31 2010 -0800 Add a little hack that ensures items have a vc_op_id when going to insert. commit 0fcfde2f90b73373b816a341c3568461b42b707b Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 19 07:58:27 2010 -0800 Bloody drupal_write_record() needs VersioncontrolItem::$source_item_revision_id to be public. commit d81c1d183d7b60d1f4308b9eb0215a44ae200f20 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 19 03:38:07 2010 -0800 Move VersioncontrolAccount::backendDelete() call to after the deletion query has been issued, for logic flow consistency with other entity classes. commit f7c9956c7c2ea1c3088a00b898905d2c7ff2e6ad Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 19 03:31:37 2010 -0800 On all CRUD methods, ensure error check comes first, then set default options. commit 663c7a8a67799201b17f6910cf4a7c12dc3ba045 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 19 03:30:10 2010 -0800 Missed a final keyword to remove. commit e566cdb94afdb9447c4bcb2f0415b63069d38203 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 19 03:26:11 2010 -0800 Restoring the backend*() crud methods on VersioncontrolRepository, which were accidentally taken out. commit 4181d7daa26894d29d4c89d1d648fbafac147f29 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 19 03:25:34 2010 -0800 No default value on the base entity backend*<crud>() methods - they're internal-use only, so they should always be called properly. commit 70182b87c2b36289f4d1b87ea21eb1ad744a815f Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 19 03:15:23 2010 -0800 Minor tweaks to VersioncontrolAccount; however, we're pretty much ignoring it right now, so not doing any serious revamping. commit c4e272ef4acb1b74528540879fca434c858ff783 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 19 03:10:22 2010 -0800 Large number of changes arising from marvil07's review at #879858-14. commit 88d325d58542e5bf77203dd30fa86ea575999df4 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 18:05:23 2010 -0800 Clean up the {versioncontrol_operation_labels} when deleting a tag. commit 5c7b58da161188d96aa48f54def40e5019923a3d Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 18:05:04 2010 -0800 Add a property declaration for the array containing referenced VersioncontrolItem objects. commit 8dfa3a04e58b67ebc4119243d85d17b3eac66207 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 17:40:48 2010 -0800 VersioncontrolItem::sanitize() is an older, crufty way of ensuring data correctness - it's being gradually replaced by the new CRUD system. commit ece38d0efb21a95359aeda399d89a47d8ee0bf51 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 17:38:00 2010 -0800 Removing accidental duplicate method. commit 1f81821b14ede854e0060d7aeb8b338a0ac0d4bc Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 17:32:17 2010 -0800 Remove old-school item loader from VersioncontrolRepository. commit 257171a0af6e5ba6e0690d89353e382a8db5f167 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 17:31:41 2010 -0800 Introduce default options and nesting onto VersiocontrolRepository. commit 1b30b3f52dc5f6eefbf3b7944fe30d6312dc312a Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 17:25:37 2010 -0800 Introduce logic for dealing with source items into the update/insert methods of VersioncontrolItem. commit 880ac513c154ea38b57907de9968edc8807e68e6 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 17:25:01 2010 -0800 Clean up some of the VersioncontrolItem properties, and bring them into keeping with the merging of the versioncontrol_source_items table into the versioncontrol_item_revisions table. commit 1c78b3034927a401a3c1eb957d3ff21cafb5acda Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 17:23:31 2010 -0800 Make VersioncontrolItem::sourceItem protected, and add getter and setter methods for it. commit d56a4c3ccb4a305995f0c3f046363ce0dd4630aa Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 15:52:24 2010 -0800 Initial poking at the complex insert operation problem with VersioncontrolItem + source item. commit 86fff16a8d91055d767437328621a3d76a924f6c Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 15:47:25 2010 -0800 Make VersioncontrolOperation strip out entries from {versioncontrol_operation_labels} as it should. commit 0c3548a2a7a25e915106b52f2f738377e22ad338 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 15:47:07 2010 -0800 Introduce default option-setting on VersioncontrolItem. commit 0e037ef942e3cf8c96cb647973332e7580ee7722 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 15:43:36 2010 -0800 Update VersioncontrolBranch to do proper nested deletions on all its contained commits. commit 5aae9f3e95a2895fc5181d5bcfe5c9b0e825863a Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 14:39:47 2010 -0800 Add default-option-appending to VersioncontrolTag, even though it's not currently using it. commit dad9ec5ca2f9db4abe57843b19319e84cecdc76c Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 13:52:38 2010 -0800 Update VersioncontrolOperation to allow nested deletes, which loops through item revisions associated with the commit and deletes them. commit 7863df990151d825e43cd792baa3d071a19b7480 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 13:52:13 2010 -0800 Introduce a system for defining default options for appending to the CRUD operation parameters. commit 0076967696e413044091a4d7ba1b53912bf65dcd Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 13:50:42 2010 -0800 Remove VersioncontrolItem::insertSourceRevision(). With #975864, we no longer need separate logic for managing source items, as they've all been integrated into the same table. commit 0939297448a51fb2f749fd3249a27df865946869 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 18 13:50:01 2010 -0800 Remove the old item-loading logic and replace it with controller-based loading. commit 696e9c7aed6b6f305059c5190585dbd92a61bd4b Author: Sam Boyer <drupal@samboyer.org> Date: Tue Nov 16 17:46:02 2010 -0800 Catch up VersioncontrolOperation CRUD to the rest of the entities. Note that this rips out a bunch of nested object manipulation logic that we really ought to provide. Need to restore that, and in a systematic way. commit 22847f00542747f83afa1ab8b83c68138ff91f53 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Nov 16 17:45:10 2010 -0800 Forgot to execute the delete queries on most of the entity delete methods. commit 8f4f906672855d53c76bf7234f65a95347ec8668 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Nov 16 17:11:46 2010 -0800 Add a generic $options array to the method sig for every CRUD method. commit f5b13a7ae033189a65e3795cadffb4ee6a5b959f Author: Sam Boyer <drupal@samboyer.org> Date: Tue Nov 16 17:10:16 2010 -0800 Remove the setLabels() methods from VersioncontrolOperation, we're not doing things that way anymore. commit 3612d4d9f4b0f958a5143d42fa89a0941e772bca Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 12 11:31:27 2010 -0800 Update the entities to conform to the deletion-related additions to the interface. commit 21e52225eb0c38962ae7b27a1846cbde2932f3a5 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 12 11:16:45 2010 -0800 Introduce delete-related methods onto VersioncontrolEntity and VersioncontrolEntityInterface. commit 5fe63f9d1b0538ec12c83e44927af0d252bad848 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 12 11:15:15 2010 -0800 Introduce delete methods for VersioncontrolItem and VersioncontrolTag. commit a347312a22bdbfe6d966a107f3803cdd8c892012 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Nov 12 11:13:30 2010 -0800 Cleanup unnecessary comment & incorrect empty method. commit 16c5c8dfd9ed1c5d7b2704779381263693e5605f Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 11 18:11:37 2010 -0800 No need to save branches in local var on VersioncontrolRepository::delete(). commit 716a28bc0f541a3d18b41f9fbe1d5045a0cad690 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 11 18:11:14 2010 -0800 Several small typo & error fixups to various entity CRUD methods. commit b4e5bd136e949d8223b953af68e54993cd992261 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 11 17:26:21 2010 -0800 First round of CRUD unification changes to VersioncontrolItem commit 1eca92bc02e13e464c0524e686b5dcf2682c4f65 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 11 17:25:54 2010 -0800 Update child entity classes to reflect introduction of VersioncontrolEntity::save(). commit d1a7cff4ed8d1f569e20dc7ee8916c78b5fd1879 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 11 17:09:43 2010 -0800 First round of CRUD unification changes to VersioncontrolBranch commit 6dd4b96aa4d830a7b48810dc88e71249ae33292a Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 11 17:09:17 2010 -0800 First round of CRUD unification changes to VersioncontrolRepository commit 1279f8ae0f56983ec1fdf24f3dbfbf86675346a3 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Nov 11 17:07:32 2010 -0800 Add some docblocks, and introduce VersioncontrolEntity::save() as a convenience to child classes. commit 3e78eadd899663a70a2c56c3be05a61975096b90 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Nov 9 17:09:54 2010 -0800 Add the insert(), backendInsert(), update(), and backendUpdate() methods to VersioncontrolEntityInterface. These methods are the basic skeleton for unified CRUD, to be filled out by the individual entities. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver...