User: sdboyer Branch: HEAD Date: Wed, 11 Aug 2010 10:09:53 +0000 Added files: /modules/versioncontrol/includes controllers.inc Removed files: /modules/versioncontrol/includes VersioncontrolAccountCache.php VersioncontrolRepositoryCache.php Modified files: /modules/versioncontrol CHANGELOG.txt /modules/versioncontrol/includes VersioncontrolAccount.php VersioncontrolBackend.php VersioncontrolBranch.php VersioncontrolItem.php VersioncontrolLabel.php VersioncontrolOperation.php VersioncontrolRepository.php VersioncontrolTag.php versioncontrol.rules.inc /modules/versioncontrol/tests VersioncontrolRepositoryManagementTestCase.test VersioncontrolRepositoryUnitTestingTestCase.test /modules/versioncontrol versioncontrol.admin.inc versioncontrol.info versioncontrol.install versioncontrol.module versioncontrol.pages.inc /modules/versioncontrol/versioncontrol_account_status versioncontrol_account_status.module versioncontrol_account_status.test /modules/versioncontrol/versioncontrol_fakevcs/includes classes.inc Log message: Squashed commit of the following: commit e59d5028a15d6f9cd69082252eae76e55a5abbad Author: Sam Boyer <drupal@samboyer.org> Date: Wed Aug 11 03:03:29 2010 -0700 Get all the currently written tests at least executable. Seeing failures locally, but have a feeling that might be due to some weirdness in local config. commit e59f89d84ec1f9bc6ddf65ae239211ecda3f257a Author: Sam Boyer <drupal@samboyer.org> Date: Wed Aug 11 02:48:30 2010 -0700 Lots of small fixups, cleanups, and notes as this thing gets close to committable. commit b0bbc21bef8d7b8d3344ac5755e3c462a3b89b5d Author: Sam Boyer <drupal@samboyer.org> Date: Wed Aug 11 02:47:46 2010 -0700 Got .admin.inc and .pages.inc up to speed with the new controllers and procedural gateways. commit f4ed7071d28c07790b2eaf2801d52215c9f523b6 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 23:50:00 2010 -0700 Move up the marker of where API items start. commit 202fd1ca3ace9f64412afc7db84beecc0f373608 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 23:46:51 2010 -0700 Remove all of the crap related to querybuilding for the operations loader; leaving it all to be reimplemented as needed in the controller. commit 330f35bc516a68051a470627409489086b119ed2 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 23:44:49 2010 -0700 Removing the cache classes for Repository and Account; the Operation one will stay a little while longer as reference until the statistics stuff gets moved somewhere smarter. commit d573654a206017d882f5662157a7eec78cad29b4 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 23:36:33 2010 -0700 Large incremental checkin. Contains some more updates and logic expansions to the controller classes, and most notably marks the removal of all (important) Versioncontrol*Cache calls, except in the tests and in the .pages.inc and .admin.inc files, which are all due for refactor anyway. commit bf98235cca29185322ae2e199a7fb5ed40c36423 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 14:11:32 2010 -0700 Remove the 'revisions' special case for operations loading, as it can be directly done with a simple condition. commit fa42fbdeaed7f7838a6af5600429b95fb1511345 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 14:08:39 2010 -0700 Add documentation to the VersioncontrolBackend::buildObjects() method, and make it check to ensure the string type specified is valid in addition to checking for proper parentage. commit dbe9f222f52ed524de54e38842536f0f64d03f12 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 14:07:35 2010 -0700 Make the Account controller cache on uid instead of repo_id, since that is much more likely to be unique for a given query; also overide assembleOptions to prevent caching since the join key makes things sticky. commit f310f16a8f695cff76fa8a4c88fd72ee4c279746 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 14:07:20 2010 -0700 Add a VersioncontrolEntityController::assembleOptions() method to allow child classes to override the default method of assembling options. commit 189985ef2fc592c15be7700bbf52e744278b129a Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 13:47:46 2010 -0700 Change VersioncontrolAccount::$vcs_username to VersioncontrolAccount::username for 1:1 naming parity between db and class properties. commit 5985f6c59c48a7dfb1b54ac5569d8f468ad0c94b Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 09:20:44 2010 -0700 Fix some typos in the data extender for operations. commit c24baddf6f75ff8dcec058838fac2bab12ace704 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 09:20:23 2010 -0700 VersioncontrolOperation::$labels should initialize to an empty array. commit f4e11955bcf091dde6fa8e15a35ec5e59c0d97b4 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Aug 10 09:20:02 2010 -0700 Comment out the constructor-based build. commit 435fa3a3b41d81ef557f720246a21c93d324da81 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Aug 6 06:35:19 2010 -0700 So the SelectQuery::join() method isn't chainable. Who knew. commit a48b3a85b0f87cae7c9755ee007dd705b71b32aa Author: Sam Boyer <drupal@samboyer.org> Date: Fri Aug 6 06:34:44 2010 -0700 insert() method was really clashing with some of the older code, just commenting it out for now. commit ce435ab850bf7c102b041433ad03def8e5af98b4 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Aug 6 06:33:57 2010 -0700 Make all the entities inherit from VersioncontrolEntity, make it implement ArrayAccess centrally (for now...ugh, it's so deprecated), and touch up some docblocks. commit ede7deff04ff3889b18057260876eedce6059d45 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Aug 6 05:28:26 2010 -0700 Amazingly enough, forgot to remove the ArrayAccess implementation and make the rest of the entities extend the master parent. Whoops! commit feef11d8fecbc960b2765f7b7c88e631dc170877 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Aug 6 02:50:42 2010 -0700 Introduce a delete method for branches, and their first loader. commit 39ce867a18189b287ad092d1fcd5b2230ee34ad2 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Aug 6 01:20:50 2010 -0700 Added an empty check before an is_string check on unserializing data, as PHP was emitting notices when failing to do so. commit 6198dbc7861834269c6a3c746ba9840550e38289 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Aug 6 01:15:15 2010 -0700 Initial work on the operations controller; makes extensive use of the extendData() method to append label information to the operation. commit 364ccd6b6188ad7e4edf44b5a62a8c6ef97df4a2 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Aug 6 01:13:58 2010 -0700 Add a generic single-table-tracking table add method, and make the other methods use it instead of reimplementing the same logic over and over. commit 00a967f6f101ed8870f2949e65037f39d30007b6 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Aug 6 01:11:31 2010 -0700 Copy/pasted code causing problems in the new VersioncontrolRepository::load() generic passthru; now fixed. commit f88a029d0b34f1111d6d26afbbad45d3f043807d Author: Sam Boyer <drupal@samboyer.org> Date: Thu Aug 5 19:46:41 2010 -0700 Fix typos and minor logic errors introduced by last round of hacking. commit 61cd56dc8a6b7adb08b4927de9ad70f4624ea47e Author: Sam Boyer <drupal@samboyer.org> Date: Thu Aug 5 16:47:15 2010 -0700 Add an extendData() method that child controller classes can use to perform post-query execution, pre-build operations on the fetched query output. commit 851f3da0922735524aeb8f75d02d09db24d78ded Author: Sam Boyer <drupal@samboyer.org> Date: Thu Aug 5 16:44:51 2010 -0700 Allow a repository object to be passed through and attached to entities during entity loading. This eases the process of putting loader methods onto the other entities later, which can then easily route those loads through the already-attached repository object. commit 413309fb039ef3e5ed42e1297d0d6339ae9cb3a3 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Aug 5 16:38:12 2010 -0700 Store $options passed to the controller on an internal property. This is a little lazy and possibly inadvisable as it would break with recursive calls, but makes for cleaner method signatures; if it turns out to be problematic, it can be rolled back. commit e1d666e272bd4632b55a32aecbebfa598a9206b4 Author: Sam Boyer <drupal@samboyer.org> Date: Wed Aug 4 21:49:13 2010 -0700 Introduce some basic db-writing methods into the VersioncontrolEntity class. These will probably need reworking later. commit 251c8eaef28bb428e32a45e0213d7de6d287428d Author: Sam Boyer <drupal@samboyer.org> Date: Wed Aug 4 16:58:08 2010 -0700 Roll back the change-fetched-id thing, it was just too gnarly. Introduce some code into the cache setter in case there's a reason rekeying is necessary, though. commit 88814930792e68c46c651d2d30fe29a503ebf98c Author: Sam Boyer <drupal@samboyer.org> Date: Wed Aug 4 16:31:51 2010 -0700 Added logic allowing query callers to set the key for caching. Can screw with the cache, but can make for cleaner logic and less burned cycles remapping arrays on the outside, so why not. commit 593005e2b2d47a6b7127e109f75e58fec4b65c59 Author: Sam Boyer <drupal@samboyer.org> Date: Wed Aug 4 15:50:22 2010 -0700 Some of the previously committed controller logic was out of date and/or broken; fixing it up. commit 324d4a41ab4a9ed35784faf7af9d2ca296f10594 Author: Sam Boyer <drupal@samboyer.org> Date: Wed Jul 28 22:27:58 2010 -0700 Work on entity controllers - introduced an options array for advanced query behavior control, further separated querybuilding logic for greater friendliness to subclassing, and added some documentation. commit 06eb350a8680ec74a3c84ce62b77624dcbe65b21 Author: Sam Boyer <drupal@samboyer.org> Date: Wed Jul 28 22:21:00 2010 -0700 Flipped boolean check on backend validity in the on VersioncontrolEntity constructor. commit 0e14a4535d0dda8896e38e5218027f054b0cca25 Author: Sam Boyer <drupal@samboyer.org> Date: Tue Jul 20 15:42:50 2010 -0700 Add a 'versioncontrol_' prefix to the tag added to select queries by the entity controller. commit 7da2dcb44dced524c6fea9f0d9c5264be4d9379a Author: Sam Boyer <drupal@samboyer.org> Date: Fri Jul 16 14:53:49 2010 -0700 Add a data field to the labels tabel. commit c42e1cefda22a000122edb1005da4b33271f8d8e Author: Sam Boyer <drupal@samboyer.org> Date: Fri Jul 16 14:52:36 2010 -0700 Strip out the now-obsolete repository constraint constructor. commit c5cb6037804201ad73b9f50d19e4a79c7e973bdf Author: Sam Boyer <drupal@samboyer.org> Date: Thu Jul 15 22:47:16 2010 -0700 Stop using VersioncontrolLabel entirely; updated controllers and entity classes accordingly. Also fixed up some stale method calls and the logic for adding backend selection. commit 32437d5537a55bfd8d6474ba93d86e3ba9b313ce Author: Sam Boyer <drupal@samboyer.org> Date: Thu Jul 15 20:55:22 2010 -0700 Remove the query modification callback and shift it onto a separate branch. If this gets implemented in the future, work on it then and reintegrate. commit 041eb82ee350a6ada66e2c40dcbce28b0f209d3d Author: Sam Boyer <drupal@samboyer.org> Date: Thu Jul 15 20:40:42 2010 -0700 Note to finish documentation. commit 6899002e580db6e60a4e9aaeee43ee7574973efb Author: Sam Boyer <drupal@samboyer.org> Date: Thu Jul 15 03:22:18 2010 -0700 Comment out passing in backends to the constructor - this is no longer necessary. commit a79161d331db0588d136a2dc910410a5b06ce41d Author: Sam Boyer <drupal@samboyer.org> Date: Thu Jul 15 03:21:54 2010 -0700 Make the repo listing page use the new logic. It works! Amazing! commit 80f0d93434aa15af09b65a1ee0694923f55c072d Author: Sam Boyer <drupal@samboyer.org> Date: Thu Jul 15 03:20:21 2010 -0700 Minor, but crucial, fixups. commit f2c90034715c38eb26f28557674fe7e71f1e8084 Author: Sam Boyer <drupal@samboyer.org> Date: Thu Jul 15 00:15:03 2010 -0700 Moved responsibility for handling single-backend mode entirely into the controllers. commit 1fe48ce2c6937526805e17869b112a7c8515d2fa Author: Sam Boyer <drupal@samboyer.org> Date: Thu Jul 15 00:02:41 2010 -0700 Not doing ArrayAccess anymore commit ef9f27706cc823cd778c923e55af0419d1f22d71 Author: Sam Boyer <drupal@samboyer.org> Date: Wed Jul 14 23:53:15 2010 -0700 Introduced a multiloader and a single-backend-mode flag. commit 6103cc9295dbf0ed0cfd8c0d077acc94bb7d796c Author: Sam Boyer <drupal@samboyer.org> Date: Wed Jul 14 19:06:37 2010 -0700 Allow versioncontrol_get_backends() to take a parameter for single-backend retrieval. commit 2364194f3c283828c53a94120379103368927de0 Author: Sam Boyer <drupal@samboyer.org> Date: Wed Jul 14 18:57:29 2010 -0700 Docblock tweak. commit c781350645dd3be73929d05ab88b427c9b128c63 Author: Sam Boyer <drupal@samboyer.org> Date: Wed Jul 14 18:41:25 2010 -0700 Move controllers into controllers.inc, update the autoloader commit 37afa9978f2f8f213defe4cba965beaa541d74e1 Author: Sam Boyer <drupal@samboyer.org> Date: Sun Jul 4 11:50:32 2010 -0700 Initial pseudocode for a VersioncontrolRepository::getLabels() method that utilizes an entity controller stored on the Repository object itself. commit 352eddbc8ff79d0ddb2e4b2ac60e966fbac8bc14 Author: Sam Boyer <drupal@samboyer.org> Date: Sun Jul 4 11:49:55 2010 -0700 Add an optional callback for direct query modification. Note that this potentially screws with caching, so we may not want to retain this approach. commit afbd9d752c573d86237e36fdb3bc05d87238cb89 Author: Sam Boyer <drupal@samboyer.org> Date: Sun Jul 4 09:26:08 2010 -0700 Update the backends to allow them to alter queries as they are being built by the entity controller. commit c089c5d7e070d69d1aea0ce48c936c0eb0f194fb Author: Sam Boyer <drupal@samboyer.org> Date: Sun Jul 4 09:21:17 2010 -0700 Note about class listings for factory behavior of VersioncontrolBackend commit 019219fe1d310083d03f4903188f6e557a4d4957 Author: Sam Boyer <drupal@samboyer.org> Date: Fri Jul 2 08:48:56 2010 -0700 Initial refactor of the VersioncontrolRepository class to make it properly receive data loaded by the entity controllers via the backend. commit b93289d9835a54d2104f7089016b5911ffe3f68a Author: Sam Boyer <drupal@samboyer.org> Date: Fri Jun 18 15:37:57 2010 -0700 Initial commit of an entities-based approach. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/CHA... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/inc... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/tes... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/tes... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver...