User: stalski Branch: DRUPAL-6--3 Date: Sun, 22 Feb 2009 20:59:53 +0000 Added files: /modules/heartbeat/includes heartbeatmessagebuilder.inc heartbeatparser.inc Modified files: /modules/heartbeat/hb_activity/modules/friendlist_activity friendlist_activity.module friendlist_activity.rules_defaults.inc /modules/heartbeat heartbeat.admin.inc heartbeat.module /modules/heartbeat/includes heartbeat.inc Log message: Fixed lots of bugs of intern issue queue The grouping of messages is fixed now I found a big error in my code while storing the relations of a user. Fixed. The public and private heartbeat have been altered due to a big change in code. A peer review indicated that refraction was needed. The sollution we came up with is a message builder as context of a state pattern. The concrete state objects are derived from a base heartbeat access object performing certain taks for all states. Little implementation of a template method pattern. Furtheron the heartbeat stores its info about relations. (init hook used to store data to the heartbeat_relations in the global user object). This info can easily be retrieved from a heartbeat instance. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/heartbeat/includes... http://cvs.drupal.org/diff.php?path=contributions/modules/heartbeat/includes... http://cvs.drupal.org/diff.php?path=contributions/modules/heartbeat/hb_activ... http://cvs.drupal.org/diff.php?path=contributions/modules/heartbeat/hb_activ... http://cvs.drupal.org/diff.php?path=contributions/modules/heartbeat/heartbea... http://cvs.drupal.org/diff.php?path=contributions/modules/heartbeat/heartbea... http://cvs.drupal.org/diff.php?path=contributions/modules/heartbeat/includes...