User: sime Branch: DRUPAL-5--4 Date: Tue, 18 Mar 2008 01:24:01 +0000 Modified files: /modules/ecommerce/ec_customer ec_customer.module /modules/ecommerce/product product.admin.inc product.inc product.install product.module Log message: * Big reorg of product module. No logic changes. * Ignored alpha ordering of functions - adds no benefit, can be done with good text editor. * moved hook_menu to top where it usually is found - useful for scanning the functionality of a module! * moved some related functions together. * killed product.inc and distributed functions to other files - it was confusing what is it for?? feel free to reinstate with a clear goal * made product.admin.inc include *only* functions that *only* get run on admin pages. There might be some more in product.module but generally pretty good now. * product.admin.inc is included once now - in hook_menu when the path is admin/ecsettings/ptype * Review: generally the documentation is good and this module is ship-shape, but legacy functions like hook_add, hook_delete, etc, these should be moved to a legacy module, and ecommerce shouldn't be creating a 'product' node type on a new install. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/ecommerce/ec_custo... http://cvs.drupal.org/diff.php?path=contributions/modules/ecommerce/product/... http://cvs.drupal.org/diff.php?path=contributions/modules/ecommerce/product/... http://cvs.drupal.org/diff.php?path=contributions/modules/ecommerce/product/... http://cvs.drupal.org/diff.php?path=contributions/modules/ecommerce/product/...