[contributions:jpetso] /modules/versioncontrol/commit_restrictions commit_restrictions.module /modules/versioncontrol/commitlog commitlog.module /modules/versioncontrol hook_versioncontrol.php versioncontrol-backend.inc versioncontrol.admin.inc versioncontrol.install versioncontrol.module /modules/versioncontrol/versioncontrol_fakevcs versioncontrol_fakevcs.module
User: jpetso Branch: HEAD Date: Mon, 21 Jan 2008 10:52:41 +0000 Modified files: /modules/versioncontrol/commit_restrictions commit_restrictions.module /modules/versioncontrol/commitlog commitlog.module /modules/versioncontrol hook_versioncontrol.php versioncontrol-backend.inc versioncontrol.admin.inc versioncontrol.install versioncontrol.module /modules/versioncontrol/versioncontrol_fakevcs versioncontrol_fakevcs.module Log message: Holy moly! Here comes the big fat operation factoring commit. Commits, branch operations and tag operations now derive from one base object (an "operation") which has most of its properties stored in the new {versioncontrol_operation} table. + More consolidation, less duplicate code, and less duplication in the table structure. + One operation id to rule them all. + Potential for introducing a combined versioncontrol_get_operations() function that can retrieve all three kinds of operations. Later, though. + A few bug fixes. + Comes with an upgrade path. Scary, though, I hope I won't ever have to do an update function like this again. - Even more abstraction, which makes the database scheme even harder to grasp. - One more join in important SQL queries. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/com... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/com... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/hoo... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver... http://cvs.drupal.org/diff.php?path=contributions/modules/versioncontrol/ver...
participants (1)
-
drupal-cvs@drupal.org