[drupal-devel] [bug] Fix error reporting for failed mails to users

[killes]

Issue status update for http://drupal.org/node/20139

 Project:      Drupal
 Version:      cvs
 Component:    user.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  nedjo
 Updated by:   killes at www.drop.org
 Status:       patch

user_mail() has no idea of the context in which it is called. So error
messages would be vague at best. I think the patch should go in as it
is.


killes at www.drop.org



Previous comments:
------------------------------------------------------------------------

April 7, 2005 - 19:12 : nedjo

Attachment: http://drupal.org/files/issues/user-mail-error-messages.patch (7.2 KB)

The user module has error handling for failed emails sent on password
changing, but not yet in other cases, so that users may register and
get a message that email has been sent when in fact it has not, an
issue reported, e.g., here [1].  This patch adds tests for mails sent
on  user registration, generating appropriate user feedback (e.g., 
"Unable to send mail", etc.) and logs errors to the watchdog.
[1] http://drupal.org/node/20026


------------------------------------------------------------------------

April 7, 2005 - 19:16 : killes at www.drop.org

Looks goog, +1. I also consider the lack of tests a bug.


------------------------------------------------------------------------

April 7, 2005 - 20:49 : Dries

Maybe we can extend user_mail() to log failed mail() attempts?  Like
that, all such instances would automatically get logged.