[drupal-devel] [bug] conf_init should strip out port numbers in bootstrap.inc

[bwooster47]

Issue status update for http://drupal.org/node/19934

 Project:      Drupal
 Version:      cvs
 Component:    base system
 Category:     bug reports
 Priority:     normal
 Assigned to:  chx
 Reported by:  bwooster47
 Updated by:   bwooster47
 Status:       patch

Regarding update #3 - does this mean the code has made it in, and will
be available in the next release?


Secondly: I follow the logic for the update, and it makes sense for
non-standard HTTP port numbers, but not sure if the logic is valid when
port 80 is used.


For example, http://yourdomain.com/ and http://yourdomain.com:80/ both
will go to the exact same page, but looks like the search for the
conf.php will be different.
Not sure if this matters...




bwooster47



Previous comments:
------------------------------------------------------------------------

April 3, 2005 - 23:07 : bwooster47

The latest Drupal from CVS (4.6.0) offers multisite configuration files,
but currently the conf_init function in includes/bootstrap.inc will also
include the :portnum URL specification in the directory name, which does
not seem right (and the colon character may cause problems on
Mac/Windows).


Snippet from bootstrap.inc:
 * Example for a fictitious site installed at
 * http://www.drupal.org/mysite/test/ the 'settings.php' is
 * searched in the following directories:
.....


If the site is: http://www.drupal.org:8080/mysite/test/
the same list of directories should be searched as listed in the
example in the file, and the :8080 should not be added to the directory
name (I think...)


I don't know enough PHP to submit a patch, but this is probably easy
for those who know this stuff :-)




------------------------------------------------------------------------

April 8, 2005 - 07:08 : chx

Attachment: http://drupal.org/files/issues/conf_init_ports.patch (768 bytes)

Here you are.




------------------------------------------------------------------------

April 8, 2005 - 11:16 : Dries

Won't commit.  Removing the port seems like a bad idea (I could have two
drupal sites at two different ports but otherwise identical URLs) and
adding regex' all over the map isn't advised.  If ":" is an invalid
character, then there might be more such characters.  I suggest we
replace them with '.' and that we document this behavior much like we
do with $db_url.




------------------------------------------------------------------------

April 11, 2005 - 23:25 : chx

Attachment: http://drupal.org/files/issues/conf_init_ports_0.patch (1.35 KB)