[drupal-devel] [bug] Missing <div> container on HTML output

[moshe weitzman]

Issue status update for http://drupal.org/node/20079

 Project:      Drupal
 Version:      cvs
 Component:    book.module
 Category:     bug reports
 Priority:     minor
 Assigned to:  Anonymous
 Reported by:  budda
 Updated by:   moshe weitzman
 Status:       patch

Stefan - menus can be used anywhere. the user block is just the most
common place to see one. that div is appropriate.




moshe weitzman



Previous comments:
------------------------------------------------------------------------

April 6, 2005 - 12:46 : budda

Line 588 should be made to output the tree navigation within a 
container the same as the core navigation block - to keep consistent.


new line 588:
    return '<div class="menu"><ul>'. $tree .'</ul></div>';

You are still able to format the book tree navigation different to the
core navigation block as this tree is a child of css class
'book-block'.




------------------------------------------------------------------------

April 6, 2005 - 12:48 : killes at www.drop.org

Attachment: http://drupal.org/files/issues/book_28.patch (558 bytes)

Here's the patch.




------------------------------------------------------------------------

April 6, 2005 - 14:34 : Dries

Where does Drupal core emit a class="menu" ?




------------------------------------------------------------------------

April 6, 2005 - 14:43 : jhriggs

Line 89 of menu.module in menu_block():


  $data['content'] = '<div class="menu">'. theme('menu_tree', $delta)
.'</div>' ;

Should the change maybe be made to theme_menu_tree() instead to take
care of all of them at once?  And if so, should the class be called
"tree" rather than "menu"?




------------------------------------------------------------------------

April 7, 2005 - 04:26 : budda

Class "tree" would be good. But would this change break any existing
themes?
Also - the tree menu is used within the book pages at the footer to
show nested pages - so would you want that to be within the same class?




------------------------------------------------------------------------

April 7, 2005 - 07:23 : stefan nagtegaal

Why don't we remove the menu-<div>??
We can style it using .block-user etc, right?


Stefan.