[drupal-devel] [task] Consistent return 'passive voice' in form_set_error() and drupal_set_message()

stefan nagtegaal drupal-devel at drupal.org
Fri Apr 22 12:05:29 UTC 2005

Issue status update for http://drupal.org/node/15595

 Project:      Drupal
 Version:      cvs
 Component:    base system
 Category:     tasks
 Priority:     normal
 Assigned to:  stefan nagtegaal
 Reported by:  bertboerland at www.drop.org
 Updated by:   stefan nagtegaal
-Status:       active
+Status:       patch

Setting status to Patch.

stefan nagtegaal

Previous comments:

January 14, 2005 - 15:59 : bertboerland at www.drop.org

*My* drupal not *Yours*!

I think that when one addresses the user or the administrator of a
site, it is best to do this outside in instead of inside out. So when
in the documentation the coder is referring to the site of the
administrator, this site should be called "your site" (/inside out/)
but "my site" (/outside in/). There are numours examples where the text
in referring to "your"where "my"would be apopriate [1]

There used to be some "your" in the userinterface for the enduser as
well, but that has been solved in 4.5. Before that you had "my
account", but "track your postings". This has now all beens replaced by
"my"and "mine". If everybody agrees, lets also corect this for the
administrator as well; my administrator, not yours ;-)

[1] examples:
admin/logs/referrers "...that point to your web site."
admin/settings "General configuration options for your site"


April 19, 2005 - 18:36 : stefan nagtegaal

We should consistently use the 'passive voice', when returning messages
using form_set_error() and drupal_set_message().


April 22, 2005 - 14:05 : stefan nagtegaal

Attachment: http://drupal.org/files/issues/drupal_set_message consistency part 1 of 2 (51.16 KB)

first patch of 2 to make the drupal_set_message(), form_set_error() and
watchdog() messages more consistent.

please review/comment and apply..

More information about the drupal-devel mailing list