[drupal-devel] [feature] favicon patch for themes

nysus drupal-devel at drupal.org
Sat Apr 23 15:06:12 UTC 2005

Issue status update for http://drupal.org/node/20809

 Project:      Drupal
 Version:      cvs
 Component:    theme system
 Category:     feature requests
 Priority:     normal
 Assigned to:  nysus
 Reported by:  nysus
 Updated by:   nysus
 Status:       patch
 Attachment:   http://drupal.org/files/issues/favicon2.patch (6.01 KB)

Here is a revision to the patch based on the feedback received on the
discussion list.  You can now override the default favicon the same you
way you can override the default site logo.  There is one difference: 
When a logo is uploaded, it is checked to determine whether it is a
valid image file using PHP's getimagesize function.  Since this
function does not work with .ico files, no validation of the uploaded
file is performed.  Advice on how (or if) validation needs to be
done---or any other suggestions and corrections---is welcome.


Previous comments:

April 18, 2005 - 19:42 : nysus

Attachment: http://drupal.org/files/issues/favicon.patch (4.57 KB)

Here is a patch that allows a user to manually set the path to the
"favicon.ico" file.  It makes a single change to the user interface: it
adds a text field to the "Logo image setting" section of the
"themes/settings" page.

This is especially useful for sites sharing a single code base as you
no longer need to create a new theme just so you can have a distinct


April 23, 2005 - 00:28 : Steven

There is a lot of mailing list discussion about this patch.

One more note though: the <link /> tags are missing the trailing slash
for XHTML.

More information about the drupal-devel mailing list