[drupal-devel] [bug] Users with 'maintain books' or 'edit own book pages' permission cannot delete book pages

[clydefrog]

Issue status update for http://drupal.org/node/21559

 Project:      Drupal
 Version:      cvs
 Component:    book.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  clydefrog
 Updated by:   clydefrog
 Status:       patch

I think it's clear that "maintain books" implies the ability to edit and
delete book pages.


No other node module provides a "delete own " permission, so it would
be inconsistent for book.module to provide it. Can you provide some
examples to justify the inconsistency?


These permissions do not affect nodes which aren't book pages but are
in a book. Those nodes are controlled by their respective type-specific
permissions, but only users with "maintain books" permission can add or
remove those nodes from books. I believe this is the correct behavior.




clydefrog



Previous comments:
------------------------------------------------------------------------

April 28, 2005 - 21:32 : clydefrog

Attachment: http://drupal.org/files/issues/delete_own_book_pages.patch (626 bytes)

AFAICT, only 'administer nodes' permission allows deletion of book
pages.


This patch allows users with 'maintain books' or 'edit own book pages'
permission to delete book pages. The logic doesn't check if the node
has updates pending. Should it?




------------------------------------------------------------------------

April 29, 2005 - 07:10 : clydefrog

It's a patch, duh.




------------------------------------------------------------------------

April 29, 2005 - 07:21 : rivena

If maintain books is a permission that overlaps other permissions, it
should say so.  For example, /maintain books (create, edit, and delete
all book pages)/.  


While I agree that someone who has been given maintainer status should
be able to delete pages, I wonder if 'delete own pages' should be made
into a seperate permission.  I could see a situation where I would not
want someone to be able to delete their own pages.


Do these permissions affect things that are not book pages but have
been put into books?


Anisa.
It's /Golden Week/!