[drupal-devel] [task] Remove theme_pager_detail()
Bèr Kessels
drupal-devel at drupal.org
Tue Aug 2 11:24:05 UTC 2005
Issue status update for
http://drupal.org/node/27980
Post a follow up:
http://drupal.org/project/comments/add/27980
Project: Drupal
Version: cvs
Component: base system
Category: tasks
Priority: normal
Assigned to: drumm
Reported by: drumm
Updated by: Bèr Kessels
Status: patch (code needs review)
another -1. This theme function was added to allow better themeing of
teh pager. Before this function we could only go for the standard
pager, now we can theme it much nicer.
Bèr Kessels
Previous comments:
------------------------------------------------------------------------
Mon, 01 Aug 2005 20:18:04 +0000 : drumm
This themeable function is not used in core. It is used once in contrib.
The author of that module is okay with removing it.
------------------------------------------------------------------------
Mon, 01 Aug 2005 22:25:10 +0000 : Jeremy at kerneltrap.org
The idea is to make it available for use in themes, modules, etc, to
design custom pagers. Why exactly do you need to remove it?
------------------------------------------------------------------------
Tue, 02 Aug 2005 03:07:38 +0000 : moshe weitzman
i agree with jeremy. can't we find more meaningful patches than ones
which strip themeability. I can't evaluate the patch because I don't
see a file. maybe thats a bug, or drumm just forgot.
not everyone uses our google ripoff pager. i have customized this in
the past for clients. you can't look at contributed themes and then
conclude that a theme function is not used.
More information about the drupal-devel
mailing list