[drupal-devel] [feature] Comment module does not support extension of its forms

[moshe weitzman]

Issue status update for 
http://drupal.org/node/14708
Post a follow up: 
http://drupal.org/project/comments/add/14708

 Project:      Drupal
 Version:      cvs
 Component:    comment.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  tangent
 Updated by:   moshe weitzman
-Status:       patch (code needs review)
+Status:       patch (code needs work)

it seems that the patch at http://drupal.org/node/28255 is more
consistent with nodeapi and more thorough. if someone else agrees,
please mark this issue as a dupe of that one.




moshe weitzman



Previous comments:
------------------------------------------------------------------------

Wed, 22 Dec 2004 23:20:44 +0000 : tangent

The comment module currently does not support 3rd party modules being
able to add form elements or form validation. This is important for the
captcha module to be able to add an extra form item.




------------------------------------------------------------------------

Wed, 22 Dec 2004 23:22:07 +0000 : tangent

Attachment: http://drupal.org/files/issues/comment.form.patch (824 bytes)

Here is a patch.




------------------------------------------------------------------------

Thu, 23 Dec 2004 11:54:00 +0000 : Anonymous

Haven't tested it, but it seems identical to the changes I'd made for my
experiments.


+1 for this. This is important to have if people want captchas on
comments.


Other modules that I think can benefit by this: Ratings (rate the post
along with commenting on it).




------------------------------------------------------------------------

Thu, 23 Dec 2004 12:15:44 +0000 : moshe weitzman

this is a good direction for hook_comment(). for consistency with
nodeapi, i propose splitting into 'form pre' and 'form post' operations
and also adding a 'view' operation.




------------------------------------------------------------------------

Thu, 23 Dec 2004 14:37:56 +0000 : tangent

I agree with the commentapi thing (however it is named or done) for
several reasons. In the short term though, in order to use a captcha
module immediately, it wouldn't hurt to update the existing code to
support the purpose since I suspect the aforementioned redesign will
not happen overnight.




------------------------------------------------------------------------

Fri, 24 Dec 2004 06:48:13 +0000 : TDobes

There's a similar discussion going on in another issue [1]... one of
these should be marked as a duplicate.
[1] http://drupal.org/node/13539




------------------------------------------------------------------------

Fri, 24 Dec 2004 11:51:35 +0000 : stefan nagtegaal

Just not to forget:
If such a patch like this makes it into core it would be nice to strip
down the comment.module untill it is a real api.
Removing the comment moderation part into an cmoderation.module would
be a good thingtm. This way we make drupal more flexible and light
weight...




------------------------------------------------------------------------

Sat, 22 Jan 2005 09:41:25 +0000 : stefan nagtegaal

Duplicate of http://drupal.org/node/13539..




------------------------------------------------------------------------

Sat, 02 Apr 2005 13:59:32 +0000 : escoles

I'm not clear on how to apply this patch. The name of the file is
"comment.form", not "comment.module"; is that simply an error? Or
should I be able to find a resource somewhere with the filename
"comment.form"?


Related question: If I operate on the assumption that the filename
should be "comment.module" and try to run patch, I get the error
message "Only garbage was found in the patch input." Does anybody know
what that would mean?




------------------------------------------------------------------------

Mon, 04 Apr 2005 12:13:11 +0000 : jotarp at www.jotarp.org

Attachment: http://drupal.org/files/issues/comment.module_7.patch (674 bytes)

Try this.




------------------------------------------------------------------------

Wed, 20 Apr 2005 14:19:54 +0000 : jgoerzen at changelog.complete.org

I'm running Drupal 4.6.0 with the attached patch 7.  It has been causing
me all sorts of weird session troubles [2].  Reversing the patch makes
the troubles go away.


Something is really awry here...
[2]
http://lists.drupal.org/archives/drupal-support/2005-04/msg00061.html




------------------------------------------------------------------------

Sun, 12 Jun 2005 11:49:52 +0000 : varunvnair

Is comment.module_7.patch still causing problems, esp with Drupal 4.6.1?
Just wanted to know because I wanted to enable captchas for anon users
and was thinking of applying this patch.




------------------------------------------------------------------------

Mon, 18 Jul 2005 11:27:01 +0000 : Hanu

Attachment: http://drupal.org/files/issues/comment.module_9.patch (698 bytes)

This patch works for me and my 4.6.2 installation.




------------------------------------------------------------------------

Wed, 03 Aug 2005 23:54:43 +0000 : Eaton

That above patch (v 9) Works for me on 4.6.2 as well. I'm using it in a
new custom module to impose length limits on comments, very very
useful.




------------------------------------------------------------------------

Sun, 07 Aug 2005 15:08:13 +0000 : koorneef

Attachment: http://drupal.org/files/issues/comment.module_10_0.patch (1.02 KB)

Attached patch is for CVS (post 4.6.2, dd: 2005-08-07).


Please check the patch for errors. It works on my test site but one
never knows ....