[drupal-devel] [task] Extend db_query()

Mon Aug 8 10:34:38 UTC 2005

Issue status update for 
http://drupal.org/node/17656
Post a follow up: 
http://drupal.org/project/comments/add/17656

 Project:      Drupal
 Version:      cvs
 Component:    database system
 Category:     tasks
 Priority:     normal
 Assigned to:  killes at www.drop.org
 Reported by:  killes at www.drop.org
 Updated by:   Bèr Kessels
 Status:       patch (code needs review)

I cannot say anything about performance for I do not know how to
benchmark this. But I tried it, And rewrote some queries in a custom
module, to use it, and like it a lot.
The code becomes cleaner, and better readable. But above all, i see
this idea going into a very interesting and good direction: that of
'more' query builders in core'.
a +1!

Bèr Kessels

Previous comments:
------------------------------------------------------------------------

Mon, 21 Feb 2005 12:48:30 +0000 : killes at www.drop.org

Attachment: http://drupal.org/files/issues/db-query.patch (2.16 KB)

We should make our database abstraction layer more robust and ensure
that module authors can use it without string manipulations inside the
query. Several queries use implode() to get their arguments into the
query. This is undesirable as we rely on the module author to check the
keys and values of such arrays for exploitation attempts.

I have created the attached patch which shouldbe able to allow us to
not use implode anymore.

A minor problem is that all inserted values will be treated as strings.
This might be a problem with PostgreSQL at least. However, the same
strategy is already used in Drupal core without any complaints I know
of.

Summary: This patch will alow us to simplify some code in node.module,
user.module, taxonomy.module and probably others.

------------------------------------------------------------------------

Mon, 21 Feb 2005 17:03:58 +0000 : killes at www.drop.org

It's a patch.

------------------------------------------------------------------------

Mon, 21 Feb 2005 17:19:13 +0000 : killes at www.drop.org

Attachment: http://drupal.org/files/issues/db-query_0.patch (2.07 KB)

Squeezed out two lines of code after consultation with Karoly. Adds only
10 loc (plus some docs).

------------------------------------------------------------------------

Mon, 21 Feb 2005 17:23:08 +0000 : chx

Do I need to say +1?

------------------------------------------------------------------------

Thu, 03 Mar 2005 00:15:10 +0000 : killes at www.drop.org

Attachment: http://drupal.org/files/issues/db-query_1.patch (2.69 KB)

After some discussion with Adrian at Drupal Con we found out that we do
not know why node_save currently works with pgsql. It currently assumes
that all db columns are strings. It seems to work but we should not rely
on it.

Here is a patch that checks for the type of field that is inserted.

It needs testing.

------------------------------------------------------------------------

Tue, 26 Jul 2005 01:17:04 +0000 : drumm

+1 for making this into an API. I've seen too many hacked together query
builders in Drupal and Contrib. I have not tested.

------------------------------------------------------------------------

Wed, 27 Jul 2005 11:30:29 +0000 : Bèr Kessels

untested. a big +1 for the feature

------------------------------------------------------------------------

Wed, 27 Jul 2005 11:41:52 +0000 : killes at www.drop.org

the patch still applies. the new patch here updates node_save to use it.
Untested.

------------------------------------------------------------------------

Wed, 27 Jul 2005 11:42:24 +0000 : killes at www.drop.org

Attachment: http://drupal.org/files/issues/node-%a.patch (926 bytes)

the patch still applies. the new patch here updates node_save to use it.
Untested.

------------------------------------------------------------------------

Wed, 27 Jul 2005 11:45:17 +0000 : Cvbge

"After some discussion with Adrian at Drupal Con we found out that we do
not know why node_save currently works with pgsql.

"
Well, it does not work. Real life exampless of not-working include
flexinode (my experience) and forum module (as someone reported).
Probably also others.

The bug occurs when a normal user (but with necessarily rights) adds a
node and he has no controls (the 'moderated', 'sticky',  'published'
etc). The, in node_load() $node->sticky, $node->moderated (and maybe
others) are set to FALSE (or TRUE, but in this case it works).
When doing printf("%s", FALSE) the FALSE is change to empty string. The
sticky and moderated db fields are numeric and postgresql do not accept
'' (empty string) as a value of integer type.

The result is for example such error:

warning: pg_query(): Query failed: ERROR:  invalid input syntax for
integer: "" in ..../includes/database.pgsql.inc on line 45.
user error:
query: INSERT INTO node (title, uid, type, teaser, status, moderate,
promote, sticky, body, comment, created, changed, nid) VALUES('xx',
'2', 'flexinode-1', '<div class="flexinode-body flexinode-1"><div
class="flexinode-image-3"><div class="form-item">
 <label>Zdjęcie:</label><br />
 <img alt="xx" src="..../pliki/" /><br />Get original file (28KB) [1]
</div>
</div></div>', '1', '', '1', '', '<div class="flexinode-body
flexinode-1"><div class="flexinode-image-3"><div class="form-item">
 <label>Zdjęcie:</label><br />
 <img alt="xx" src="..../pliki/" /><br />Get original file (28KB) [2]
</div>
< in ..../includes/database.pgsql.inc on line 62.
[1] http://drupal.org/..../pliki//tmp/male.jpg
[2] http://drupal.org/..../pliki//tmp/male.jpg

------------------------------------------------------------------------

Wed, 27 Jul 2005 13:03:14 +0000 : Cvbge

Attachment: http://drupal.org/files/issues/node.module_5.diff (500 bytes)

Here's a quick fix for 4.6

------------------------------------------------------------------------

Wed, 27 Jul 2005 13:10:54 +0000 : killes at www.drop.org

Attachment: http://drupal.org/files/issues/node-a.patch (1.8 KB)

the last patch wasn't good.

------------------------------------------------------------------------

Mon, 08 Aug 2005 08:19:14 +0000 : killes at www.drop.org

Attachment: http://drupal.org/files/issues/db_api_taxonomy.patch (3.5 KB)

Here is an additional patch for taxonomy.module
it removes the two custom functions that are used for inserts and
updates.
Needs testing.

@Cvbge: shoduld we have a better test than just is_numeric in
_db_argument_type to fix the pgsql problems? We could also try to pass
$value by reference and cast it to int. this function is only used for
updates/inserts so we can afford an additional check.

------------------------------------------------------------------------

Mon, 08 Aug 2005 08:37:25 +0000 : killes at www.drop.org

Attachment: http://drupal.org/files/issues/db_query.patch (2.74 KB)

Here's a revised version fo the original patch. _db_argument_type now
gets the $value argument by reference and we check for bools too.
numerics and bools are cast to int.