[drupal-devel] [bug] user_login calls user_deny with empty variable

[gordon]

Issue status update for 
http://drupal.org/node/11031
Post a follow up: 
http://drupal.org/project/comments/add/11031

 Project:      Drupal
 Version:      cvs
 Component:    user.module
 Category:     bug reports
 Priority:     minor
-Assigned to:  Anonymous
+Assigned to:  gordon
 Reported by:  bernardo
 Updated by:   gordon
-Status:       active
+Status:       patch (code needs review)
 Attachment:   http://drupal.org/files/issues/user_28.patch (691 bytes)

here is a small problem that fixes this. It actually reduces the queries
by 4 not including and also the actual user authentication.




gordon



Previous comments:
------------------------------------------------------------------------

Thu, 23 Sep 2004 15:14:29 +0000 : bernardo

In the user_login function, user_deny is called even if $edit['name'] is
empty (for example when the login form is displayed for the first time).
I think this performs 2 unnecessary database queries.