[drupal-devel] [task] Make local tasks more themeable

ax drupal-devel at drupal.org
Fri Aug 12 15:09:13 UTC 2005

Issue status update for 
Post a follow up: 

 Project:      Drupal
-Version:      <none>
+Version:      4.6.0
 Component:    menu system
 Category:     tasks
 Priority:     normal
 Assigned to:  drumm
 Reported by:  drumm
 Updated by:   ax
-Status:       closed
+Status:       patch (code needs work)

this (committed) patch removes [1] the ability to return a rendered tree
of all accessible menu items [2], a feature critical for DHTML
expandable menu links.

is this supposed behaviour? "Make local tasks more themeable" doesn't
suggest this.

is there another way to get an completely expanded menu tree with
proper menu item class labeling? ie. for "node/add":

[li class="***expanded***"]create content
[li class="leaf"]blog entry[/li]
[li class="leaf"]story[/li]
[li class="leaf"]my account[/li]
[li class="leaf"]submission queue[/li]
[li class="***collapsed***"]administer
[li class="leaf"]access control[/li]
[li class="leaf"]...[/li]

if not, i would kindly request to reinstate this functionality. i will
try to provide a patch, but would much appreciate any help, especially
of those who have more experience with the menu system.

thank you!
[1] http://drupal.org/node/5943#comment-38932
[2] http://drupal.org/node/5943#comment-10080


Previous comments:

Thu, 24 Feb 2005 08:51:23 +0000 : drumm

There is currently a lot of code that does some heavy lifting in the
local task themeable functions. This is a bit of a simplification. No
HTML is changed by this refactoring.

To test this I tried making the local tasks hierarchical instead of two
unordered lists. This was a easy change to do, with about 3 lines of


Thu, 24 Feb 2005 10:19:58 +0000 : drumm

Attachment: http://drupal.org/files/issues/menu.inc_2.diff (6.08 KB)


Mon, 28 Feb 2005 12:15:52 +0000 : Bèr Kessels

+1 from me.
This will make the code I am working on for primary/secondary links a
huge lot easier.
Also: this makes tabs semantically correct.


Mon, 28 Feb 2005 16:23:44 +0000 : Dries

Committed to HEAD.

More information about the drupal-devel mailing list