[drupal-devel] [bug] "Only variables can be passed by reference" to file_check_directory()

[drumm]

Issue status update for 
http://drupal.org/node/26033
Post a follow up: 
http://drupal.org/project/comments/add/26033

 Project:      Drupal
 Version:      4.6.2
 Component:    base system
 Category:     bug reports
 Priority:     critical
 Assigned to:  Anonymous
 Reported by:  danielc
 Updated by:   drumm
-Status:       patch (code needs review)
+Status:       patch (ready to be committed)

Patch still applies and does not cause any problems with PHP 4. I am
unable to test on PHP 5.




drumm



Previous comments:
------------------------------------------------------------------------

Thu, 30 Jun 2005 00:44:20 +0000 : danielc

Attachment: http://drupal.org/files/issues/file_create_path.diff (2.4 KB)

A client of mine just upgraded to the latest snapshot of PHP 5.0.5-dev
and started getting errors when file_check_directory() is called:


Fatal error: Only variables can be passed by reference in
c:\drupal\modules\system.module on line 653


This patch fixes the problem by assigning the values to variables
before passing them to file_check_directory().


Thanks.


(BTW: I'm no longer on on drupal-devel due to time constraints.)