[drupal-devel] [bug] Taxonomy_save_* return values

[killes]

Issue status update for 
http://drupal.org/node/29102
Post a follow up: 
http://drupal.org/project/comments/add/29102

 Project:      Drupal
 Version:      cvs
 Component:    taxonomy.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  chx
 Reported by:  chx
 Updated by:   killes at www.drop.org
 Status:       patch (code needs review)

The patch looks excellent and removes some crufty code. :)
Unfortunately I cannot test it right now.




killes at www.drop.org



Previous comments:
------------------------------------------------------------------------

Thu, 18 Aug 2005 04:50:50 +0000 : chx

Attachment: http://drupal.org/files/issues/taxonomy_save_return.patch (4.08 KB)

What is described on http://drupal.org/node/22218 is nice. What is in
the core is super ugly. I surely was not paying attention when did
slipped in.




------------------------------------------------------------------------

Thu, 18 Aug 2005 06:09:06 +0000 : chx

Attachment: http://drupal.org/files/issues/taxonomy_save_return_0.patch (4.08 KB)




------------------------------------------------------------------------

Thu, 18 Aug 2005 09:37:27 +0000 : DriesK

Just before I read this issue, I updated http://drupal.org/node/22218 to
reflect what is currently in core.


Until about a month ago, taxonomy_save_* functions were as in your
current patch. However, several modules (such as forum, simplenews)
need vid to be returned by taxonomy_save_vocabulary (as it was before
the status messages were introduced). Therefore, Dries committed patch
#19621 to fix this. See http://drupal.org/node/19621 and
http://drupal.org/node/26421.




------------------------------------------------------------------------

Thu, 18 Aug 2005 10:25:22 +0000 : DriesK

I was too fast. Didn't see the & in taxonomy_save_vocabulary(&$edit).
This patch indeed solves the problem in a much cleaner way.