[drupal-devel] [bug] PHP highlighting and break tag

[Uwe Hermann]

Issue status update for 
http://drupal.org/node/13599
Post a follow up: 
http://drupal.org/project/comments/add/13599

 Project:      Drupal
-Version:      4.5.0
+Version:      cvs
 Component:    node.module
 Category:     bug reports
 Priority:     normal
-Assigned to:  DocSavage
+Assigned to:  Uwe Hermann
 Reported by:  chrisada
 Updated by:   Uwe Hermann
-Status:       active
+Status:       patch (code needs review)
 Attachment:   http://drupal.org/files/issues/node_32.patch (1017 bytes)

This is still a problem in HEAD. Attached patch (slightly modified
version of the patch by DocSavage) fixes the bug. Please review / test.




Uwe Hermann



Previous comments:
------------------------------------------------------------------------

Sun, 28 Nov 2004 17:02:42 +0000 : chrisada

Using  the PHP highlighting feature stops Drupa'ls break tag from
working. No matter how long the post, or where the user manually put
the break tag, the page will never break. 


The code tag does not suffer from this.




------------------------------------------------------------------------

Sat, 05 Feb 2005 17:16:55 +0000 : DocSavage

Attachment: http://drupal.org/files/issues/node_25.patch (646 bytes)

The current version of node.module, when crafting teasers without any
helper teaser module, looks for the break tag and simply uses the
entire body for a teaser if any php code is present. It does that to
prevent breaking php code in the middle, but when php code is included
for documentary purposes, this is unnecessary. This bug is most obvious
when using the codefilter module, since php code is specifically used
for documentation.


This patch to node.module replaces the "if any php code then use body
as teaser" with code that sets teaser break points to the beginning of
the php block. It's assumed that there will be some comment before
showing the code, which suffices for a teaser.




------------------------------------------------------------------------

Fri, 04 Mar 2005 18:50:57 +0000 : Steven

Your patch does not comply to code standards (don't use tabs, don't add
comments about who added it).


Reclassifying under node.module / core.