[drupal-devel] [bug] Time zone improperly handled in archive.module

killes drupal-devel at drupal.org
Sun Aug 21 17:44:23 UTC 2005


Issue status update for 
http://drupal.org/node/8287
Post a follow up: 
http://drupal.org/project/comments/add/8287

 Project:      Drupal
 Version:      cvs
 Component:    archive.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Goba
 Reported by:  Goba
 Updated by:   killes at www.drop.org
-Status:       active
+Status:       patch (code needs work)

Changing status.




killes at www.drop.org



Previous comments:
------------------------------------------------------------------------

Fri, 04 Jun 2004 11:00:12 +0000 : Goba

Attachment: http://drupal.org/files/issues/Drupal-archive-time.patch (706 bytes)

The user time zone values are added and substracted from local time
values (mktime() and friends), and therefore the resulting datetime
values are not right. gmmktime() should be used instead of mktime(),
since GMT is what the timezone setting is supposed to be relative to.
Here is a patch which fixes part of the problem. It would be nice if
someone with understanding of the calendar printout code (or enough
time to find out how does it work) would submit a patch against the
mktime() issues there. This patch fixes the archive_page time issue.


Probably also relevant for HEAD (patch against 4.4.x CVS)




------------------------------------------------------------------------

Fri, 04 Jun 2004 18:08:17 +0000 : Kjartan

I would like to see a complete patch that handles everything. For that
matter I would love to have the archive module improved in general.




------------------------------------------------------------------------

Tue, 01 Mar 2005 09:29:45 +0000 : Bèr Kessels

Setting this to CVS. We discussed removing this module on the Drupal
Sprint. Whenever that happens, we can close this.




------------------------------------------------------------------------

Sat, 05 Mar 2005 01:56:55 +0000 : paul at murphymaphia.com

So the solution to the problem is to just scrap the module? This patch
doesn't seem to fix the problem in my case. Is there a newer patch?







More information about the drupal-devel mailing list