[drupal-devel] [feature] show online/offline status in theme('username')

Thomas Ilsche drupal-devel at drupal.org
Mon Aug 22 21:06:16 UTC 2005

Issue status update for 
Post a follow up: 

 Project:      Drupal
 Version:      cvs
 Component:    theme system
 Category:     feature requests
 Priority:     normal
 Assigned to:  moshe weitzman
 Reported by:  moshe weitzman
 Updated by:   Thomas Ilsche
 Status:       patch (code needs work)

successfully tried the patch (in a small setup)

Thomas Ilsche

Previous comments:

Sun, 21 Aug 2005 01:01:04 +0000 : moshe weitzman

Attachment: http://drupal.org/files/issues/online.patch (9.41 KB)

add css class such that a theme can put nice online/offline indicators
when showing a username link.

i made sure the relevant queries in node, user, and tracker modules
were passing the $user->access parameter which triggers the addition of
this css class.

no added quries or JOINS needed.much of this patch is just moving the
'inactivity timer' pref from the Who's Online block config page to the
main admin/settings/user page.

would be nice if someone contributed small graphics for online offline
and added these to drupal.css. this would enhance our default
presentation. i'd like for this patch not to wait on that, if possible.


Sun, 21 Aug 2005 09:10:41 +0000 : Bèr Kessels

I really like thi. +1. I managed to grey out my avatars of offline users
(looks very good!) with this patch.

One thing is the whos online block. IMO that should follow these same


Sun, 21 Aug 2005 14:01:35 +0000 : moshe weitzman

Attachment: http://drupal.org/files/issues/online_0.patch (10.22 KB)

this feature already works for the who's new and who's online blocks.

here is a slightly improved version which adds offline indicator even
for admin created users who have not yet logged in.


Sun, 21 Aug 2005 14:30:23 +0000 : Maat at drupal.hu

I patched a clean cvs install, but there are no classes in the  tags of
names of the owners of the nodes. I didn't can fix it and I have to go
I drew the icons for the default theme:
http://maat.myip.hu/~maat/maat_drupal/drupal/misc/online.png &


Sun, 21 Aug 2005 15:03:52 +0000 : Bèr Kessels

Excuse my ignorance. This pach already changed the whos online block. My
testsite had a too complex theme function, it was causing the whosonline
block to check fro the old variable still. My error. 

But my +1 still stands, though.


Sun, 21 Aug 2005 19:31:49 +0000 : moshe weitzman

thanks for the icons ... this feature already works for the who's new
and who's online blocks. perhaps someone (steven?) can add some css to
include these images. otherwise, lets just get this improved markup


Sun, 21 Aug 2005 20:29:19 +0000 : Uwe Hermann

Moshe, I think there's a left-over in your patch from another patch(?)
Look at the bluemarine stuff at the bottom.


Sun, 21 Aug 2005 20:29:53 +0000 : Uwe Hermann

Oh, and +1 for the idea (didn't try the patch, yet).


Mon, 22 Aug 2005 02:59:49 +0000 : moshe weitzman

Attachment: http://drupal.org/files/issues/online_1.patch (9.41 KB)

indeed, uwe was correct. here is a clean patch.


Mon, 22 Aug 2005 08:07:17 +0000 : Dries

Sometimes variable_get('user_seconds_online', 2700) is used, sometimes
variable_get('user_seconds_online', 900); is used.  That can't be
right, can it?


Mon, 22 Aug 2005 12:23:55 +0000 : moshe weitzman

Attachment: http://drupal.org/files/issues/online_2.patch (9.41 KB)

2700 => 900


Mon, 22 Aug 2005 12:24:11 +0000 : moshe weitzman

Attachment: http://drupal.org/files/issues/online_3.patch (9.41 KB)

2700 => 900

More information about the drupal-devel mailing list