[drupal-devel] [feature] OPML export by category

[Prometheus6]

Issue status update for 
http://drupal.org/node/22637
Post a follow up: 
http://drupal.org/project/comments/add/22637

 Project:      Drupal
 Version:      cvs
 Component:    aggregator.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  Prometheus6
 Reported by:  Prometheus6
 Updated by:   Prometheus6
 Status:       patch (code needs review)
 Attachment:   http://drupal.org/files/issues/AGGREGATOR_OPML_2.txt (914 bytes)

"Still insecure. Use the %d-directive in db_query().

"
An implicit check that the variable is numeric. Okay.


"Also, cat_title does not seem to be used. If cat_title isn't used, why
is the category table joined?

"
Truth, I didn't think I'd be finishing this. I had a reason for that, I
just don't remember what it was. YOu're right, it's not necessary so
it's gone.




Prometheus6



Previous comments:
------------------------------------------------------------------------

Thu, 12 May 2005 02:38:13 +0000 : Prometheus6

Attachment: http://drupal.org/files/issues/AGGREGATOR_OPML.txt (1.5 KB)

Added an optional parameter to aggregator_page_opml() to specify which
category, if any, to create the OPML file for. 


Modified aggregator_menu() to crerate callbacks for the files.




------------------------------------------------------------------------

Thu, 04 Aug 2005 14:46:39 +0000 : Prometheus6

Doesn't seem to be much interest...




------------------------------------------------------------------------

Sat, 20 Aug 2005 03:09:36 +0000 : Uwe Hermann

This would be nice IMHO. Your patch seems broken, can you please
re-submit a working one?




------------------------------------------------------------------------

Sun, 21 Aug 2005 16:55:21 +0000 : Prometheus6

I've taken a different approach. I wrote a module for my site pretty
specific to my needs.


http://www.niggerati.net/sitelist


Since I know you're working on Planet Drupal, I'd be willing to ship
you a not-for-distribution copy to check out. Hit me via the contact
page if you're interested.




------------------------------------------------------------------------

Sun, 21 Aug 2005 21:13:44 +0000 : Uwe Hermann

That wouldn't help much. The Planet will run on drupal.org, so we need
patches for aggregator.module. Can you merge your changes into
aggregator module?




------------------------------------------------------------------------

Sun, 21 Aug 2005 21:43:23 +0000 : Prometheus6

Attachment: http://drupal.org/files/issues/AGGREGATOR_OPML_0.txt (1.72 KB)

All of them, no. But I did fix a problem with the initial patch. All the
callbacks will be created properly.




------------------------------------------------------------------------

Sun, 21 Aug 2005 22:29:29 +0000 : Uwe Hermann

There's a ***** CVS exited normally with code 1 ***** at the bottom of
your patch. I guess it won't apply.




------------------------------------------------------------------------

Sun, 21 Aug 2005 22:51:51 +0000 : Prometheus6

Really? Why?




------------------------------------------------------------------------

Sun, 21 Aug 2005 23:43:28 +0000 : Uwe Hermann

OK, my bad. The patch /does/ apply, but that line is some error message
(a quick Google lookup tells me that "code 0" is ok, "code 1" means
error). It seems the line is added by WinCVS, do you use that? Are you
sure the patch contains all lines it should contain? The error might
mean that some lines are missing from the patch (?) Not sure...




------------------------------------------------------------------------

Mon, 22 Aug 2005 00:54:20 +0000 : Prometheus6

"It seems the line is added by WinCVS, do you use that?

"
Guilty. But the patches it produces seem fine. It may be a return code
from the macros that run the CVS commands. I've never needed to know
what that code meant.




------------------------------------------------------------------------

Mon, 22 Aug 2005 18:46:59 +0000 : Dries

That code is insecure (SQL injection) and does not work with table
prefixing.


Plus, the callback can be removed.  Additional parameters are
automatically passed to aggregator_page_opml.




------------------------------------------------------------------------

Mon, 22 Aug 2005 19:14:51 +0000 : Prometheus6

Attachment: http://drupal.org/files/issues/AGGREGATOR_OPML_1.txt (1 KB)

Sorry, I just uploaded what was there...like I said, I'm using a
seperate module for this.


Anyway, here's a correct one.




------------------------------------------------------------------------

Mon, 22 Aug 2005 20:34:04 +0000 : Dries

Still insecure.  Use the %d-directive in db_query().  


Also, cat_title does not seem to be used.  If cat_title isn't used, why
is the category table joined?


Finally, "} else {" should be on two lines.