[drupal-devel] [feature] Replace core archive.module w/ codemonkeyx archive.module

[Tobias Maier]

Issue status update for 
http://drupal.org/node/29676
Post a follow up: 
http://drupal.org/project/comments/add/29676

 Project:      Drupal
 Version:      cvs
 Component:    archive.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  Morbus Iff
 Reported by:  Morbus Iff
 Updated by:   Tobias Maier
 Status:       patch (code needs review)

cant you provide a patch file?
thanks for your work




Tobias Maier



Previous comments:
------------------------------------------------------------------------

Thu, 25 Aug 2005 21:08:49 +0000 : Morbus Iff

Over at http://drupal.org/node/8287, Berkes mentions that the core
archive.module was considered being removed, per a discussion at the
Drupal Sprint. Kjartan also mentions he would "love to have the archive
module improved in general." In chatting with chx about this, he
mentioned codemonkeyx's rewrite sitting in contrib/modules/archive/.
I'll be doing some work with the archive.module over the next few days,
and will be basing my changes around codemonkeyx's version, and making
it compatible with HEAD. This general Issue is to move codemonkeyx's
version into HEAD as a replacement to the existing archive.module. An
unknown version of his replacement can be seen at
http://www.codemonkeyx.net/archive. I'll be running a live HEAD version
soon as well.


These patches were made during the customization of Drupal by
http://www.NHPR.org. In loving support of open source software,
http://www.NHPR.org will continue to contribute patches they feel the
community will benefit from. Questions about this patch should be
directed to morbus at disobey.com.




------------------------------------------------------------------------

Fri, 26 Aug 2005 19:45:59 +0000 : Morbus Iff

Attachment: http://drupal.org/files/issues_2 (9.56 KB)

As an example of a very early revision, see the attached, with the
following changes from the current contrib CVS:



* removed the year offset from theme_archive_navigation_years, which
controlled how many year links to show at once in the top nav. For
those with sites with more than five years, they'll WANT people to
notice that they have five years, not to have to click on the earliest
date and then have their expectations changed.
* made the "created > $date" in archive_buildQuery "created >= $date"
instead, to allow posts that were created at exactly midnight that day
(like me, by design).
* since there's no block, I made the menu item visible upon first load.
this menu item is given "access content" permissions.

More to come, including doxygen and gmt considerations.




------------------------------------------------------------------------

Fri, 26 Aug 2005 19:47:41 +0000 : Morbus Iff

Might as well start getting a review of it so I can fix 'em as they come
in.