[drupal-devel] [bug] Consistency in form elements form_autocomplete(), form_textfield() and form_textarea()

[stefan nagtegaal]

Issue status update for 
http://drupal.org/node/25603
Post a follow up: 
http://drupal.org/project/comments/add/25603

 Project:      Drupal
 Version:      cvs
 Component:    base system
 Category:     bug reports
 Priority:     normal
 Assigned to:  stefan nagtegaal
 Reported by:  stefan nagtegaal
 Updated by:   stefan nagtegaal
 Status:       patch (code needs review)

Dries, I am not against documenting this, but where? Should I document
this in the new form API from Adrian?


Stefan




stefan nagtegaal



Previous comments:
------------------------------------------------------------------------

Thu, 23 Jun 2005 12:53:44 +0000 : stefan nagtegaal

Attachment: http://drupal.org/files/issues/form_size_consistency.patch (69.9 KB)

Attached you'll find the patch for making the form element,
form_field(), form_autocomplete() and form_textarea() consistent in
size..


I used:


form_autocomplete() and form_textfield():
for numbers: width of 5;
for small textfields: width of 15 or 30;
for textfields settings, titles etc: width of 60;


form_textarea()
small textarea's: width 60, height 5 rules;
medium textarea's: width 60, height 15 rules;
large textarea's (node submission body's): width 60, height 20 rules;


please review and apply patch... I this is - for the sake of
consistency - a very fine patch..




------------------------------------------------------------------------

Mon, 27 Jun 2005 16:50:51 +0000 : wnorrix

I think this is a good idea, good way to standardize the UI.


+1




------------------------------------------------------------------------

Mon, 27 Jun 2005 18:33:26 +0000 : Dries

Committed to HEAD.  I suggest we document the defaults in the PHPdoc
comments.  Guidelines are in order to avoid inconsistency creeping in. 
I'm not marking this fixed yet.