[drupal-devel] [bug] book pages dishonor node_access

Anonymous drupal-devel at drupal.org
Thu Feb 3 23:23:25 UTC 2005

 Project:      Drupal
 Version:      cvs
 Component:    book.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  moshe weitzman
 Reported by:  moshe weitzman
 Updated by:   Anonymous
 Status:       patch

+1... the node_access fix is much-needed and the revision pending
indicator would certainly be helpful on drupal.org and other sites
using the moderation system.


Previous comments:

January 31, 2005 - 02:41 : moshe weitzman

Attachment: http://drupal.org/files/issues/tree.diff (921 bytes)

Book pages slighty disobey the node_access system because they always
return a value for book_access('update'). This simple patch causes us
to use node_access when the user has a chance of being able to update
the current page.


February 3, 2005 - 16:34 : moshe weitzman

Attachment: http://drupal.org/files/issues/book_25.patch (882 bytes)

i had the conditions reversed. thanks jonbob.


February 3, 2005 - 17:36 : sulleleven

i noticed this a while back... thnx for the patch.
would a similar reason apply to the project modules issue nodes?


February 3, 2005 - 18:11 : moshe weitzman

Attachment: http://drupal.org/files/issues/book_26.patch (1.37 KB)

this version adds a 'revision pending' message as needed at bottom of
the node view. the lack of this indicator confuses authors on
drupal.org why they have no edit tab, and may remind recent editors why
their edits are not showing up yet.
sorry for mixing two unrelated ideas in one patch. at least they affect
the same single file

View: http://drupal.org/node/16462
Edit: http://drupal.org/project/comments/add/16462

More information about the drupal-devel mailing list