[drupal-devel] [feature] Proposed change to menu.inc that would allow modules to create custom menus

andremolnar drupal-devel at drupal.org
Mon Feb 7 07:08:32 UTC 2005


 Project:      Drupal
 Version:      cvs
 Component:    menu system
 Category:     feature requests
 Priority:     normal
 Assigned to:  andremolnar
 Reported by:  andremolnar
 Updated by:   andremolnar
 Status:       patch
 Attachment:   http://drupal.org/files/issues/menu_inc_3.patch (2.65 KB)

Noticed patch was out of date - keeping it current.


andremolnar



Previous comments:
------------------------------------------------------------------------

January 6, 2005 - 07:13 : andremolnar

Attachment: http://drupal.org/files/issues/menu_inc_2.patch (2.65 KB)

See http://drupal.org/node/15153 and http://drupal.org/node/14120 for
discussion on this proposed change.
Patch is included here for further discussion (with the changes
suggested by Dries).  A patch is forthcoming for topics discussed in
http://drupal.org/node/14120 which would make use of this patch.
Status to be changed to patch later if there are no objections
following discussion.
andre


------------------------------------------------------------------------

January 8, 2005 - 21:16 : andremolnar

Patch making use of this is now added to http://drupal.org/node/14120.
andre


------------------------------------------------------------------------

January 10, 2005 - 07:29 : andremolnar

Just realising that the rules for setting status to patch would allow
this to be patch since its technically ready to go. (and it might
actually get noticed if its on the dev list and patch queue).
andre


------------------------------------------------------------------------

January 11, 2005 - 06:47 : Dries

I'm OK with this patch but won't commit it yet until the book module
patch is ready.


------------------------------------------------------------------------

January 20, 2005 - 02:07 : andremolnar

I've uploaded the latest version of the patch to book.
http://drupal.org/node/14120
andre


------------------------------------------------------------------------

January 27, 2005 - 17:38 : JonBob

I'd prefer a solution that allowed modules to declare such menu items
using the menu hook, but haven't been able to come up with such a
solution. I'm okay with this approach until such time as someone has a
brilliant idea to make the menu hook more powerful.


------------------------------------------------------------------------

January 28, 2005 - 00:00 : andremolnar

JonBob,
I'd be happy to work on a solution with you.  Right now what I had to
do in the proposed changes to book was build functions to insert data
into the {menu} table by hand since there was no other handler
available (e.g. hook_menu).  And proposing this MENU_MODULE_MENU type
was the only way I could think of to clearly distinguish where these
new menu items were coming from (i.e. a module doing an insert into the
menu system outside of the normal chanels).
 Would the creation of a new hook_ be in order.  Perhaps
hook_menu_block?  While it would be a confusing hook name - it is does
describe the desired outcome.  i.e. Output from hook_menu_block would
be inserted into the menu system and a block would be created for that
menu.
But even then I think these new menu types (or something similar) would
have to be employed in some way.
andre


-- 
View: http://drupal.org/node/15198
Edit: http://drupal.org/project/comments/add/15198





More information about the drupal-devel mailing list